[PATCH v4 4/5] drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c

[Paloma Arellano]

On 2/8/2024 10:49 AM, Abhinav Kumar wrote:
>
>
> On 2/8/2024 7:20 AM, Dmitry Baryshkov wrote:
>> dpu_encoder_phys_wb is the only user of encoder's atomic_check callback.
>> Move corresponding checks to drm_writeback_connector's implementation
>> and drop the dpu_encoder_phys_wb_atomic_check() function.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>> ---
>>   .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c    | 54 
>> -------------------
>>   drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c            |  9 ++--
>>   drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c      | 61 
>> +++++++++++++++++++++-
>>   drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.h      |  3 +-
>>   4 files changed, 68 insertions(+), 59 deletions(-)
>>
>
> <Snip>
>
>> +
>> +    crtc = conn_state->crtc;
>> +    if (!crtc)
>> +        return 0;
>> +
>
> This should fix the crash and rest of the change LGTM
>
> Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>
Tested-by: Paloma Arellano <quic_parellan at quicinc.com>
>
>
> Please give us a couple of days to re-test this and give our Tested-by 
> as we plan to rebase CDM over DP on top of this and post V2.