[PATCH v3 03/10] dt-bindings: display: bridge: tc358775: Add support for tc358765

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Mon Feb 12 11:30:12 UTC 2024


On 12/02/2024 09:17, Tony Lindgren wrote:
> * Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> [240212 08:06]:
>> On 11/02/2024 10:51, Tony Lindgren wrote:
>>> The tc358765 is similar to tc358775. The tc358765 just an earlier version
>>> of the hardware, and it's pin and register compatible with tc358775 for
>>> most part.
>>>
>>> From the binding point of view the only difference is that the tc358765
>>> does not have stdby-gpios.
>>>
>>> Signed-off-by: Tony Lindgren <tony at atomide.com>
>>> ---
>>
>> It does not look like you tested the bindings, at least after quick
>> look. Please run `make dt_binding_check` (see
>> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>> Maybe you need to update your dtschema and yamllint.
> 
> I did.. But I did not notice that this no longer works:
> 
> $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml
>   LINT    Documentation/devicetree/bindings
> usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR ...]
> yamllint: error: one of the arguments FILE_OR_DIR - is required
>   CHKDT   Documentation/devicetree/bindings/processed-schema.json
>   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
> 
> After removing the ">2&1" from the Makefile, there's some more info:
> 
> yamllint: error: one of the arguments FILE_OR_DIR - is required
> 
> Where DT_SCHEMA_FILES ends up empty. I guess dt_binding_check needs
> to be now run with just:
> 
> $ make dt_binding_check DT_SCHEMA_FILES=toshiba,tc358775.yaml
> 

Yes, since June last year. Rob later brought (in July) backwards
compatible way, but apparently something changed now in Makefile.

Anyway full Linux path should be considered deprecated. The same for
dtbs_check.

Best regards,
Krzysztof



More information about the dri-devel mailing list