[PATCH 1/1] drm: bridge: dw_hdmi: Set DRM bridge type

Neil Armstrong neil.armstrong at linaro.org
Mon Jan 8 17:00:58 UTC 2024


On 08/01/2024 16:25, Alexander Stein wrote:
> The bridge type was set to default (Unknown). Set proper bridge type.
> With this fixed, debugfs output imx8mp looks proper.
> $ cat /sys/kernel/debug/dri/1/encoder-0/bridges
> bridge[0]: imx_hdmi_pvi_bridge_funcs [imx8mp_hdmi_pvi]
>          type: [0] Unknown
>          OF: /soc at 0/bus at 32c00000/display-bridge at 32fc4000:fsl,imx8mp-hdmi-pvi
>          ops: [0x0]
> bridge[1]: dw_hdmi_bridge_funcs [dw_hdmi]
>          type: [11] HDMI-A
>          OF: /soc at 0/bus at 32c00000/hdmi at 32fd8000:fsl,imx8mp-hdmi
>          ops: [0x7] detect edid hpd
> 
> Signed-off-by: Alexander Stein <alexander.stein at ew.tq-group.com>
> ---
> For the record, the output before is:
> $ cat /sys/kernel/debug/dri/1/encoder-0/bridges
> bridge[0]: imx_hdmi_pvi_bridge_funcs [imx8mp_hdmi_pvi]
>          type: [0] Unknown
>          OF: /soc at 0/bus at 32c00000/display-bridge at 32fc4000:fsl,imx8mp-hdmi-pvi
>          ops: [0x0]
> bridge[1]: dw_hdmi_bridge_funcs [dw_hdmi]
>          type: [0] Unknown
>          OF: /soc at 0/bus at 32c00000/hdmi at 32fd8000:fsl,imx8mp-hdmi
>          ops: [0x7] detect edid hpd
> 
>   drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index aca5bb0866f88..455bc15d90cc1 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -3541,6 +3541,7 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev,
>   	hdmi->bridge.interlace_allowed = true;
>   	hdmi->bridge.ddc = hdmi->ddc;
>   	hdmi->bridge.of_node = pdev->dev.of_node;
> +	hdmi->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
>   
>   	memset(&pdevinfo, 0, sizeof(pdevinfo));
>   	pdevinfo.parent = dev;

Reviewed-by: Neil Armstrong <neil.armstrong at linaro.org>


More information about the dri-devel mailing list