[PATCH v3 01/14] drm/panthor: Add uAPI

Boris Brezillon boris.brezillon at collabora.com
Mon Jan 15 11:18:52 UTC 2024


On Mon, 18 Dec 2023 13:20:07 +0000
Chris Diamand <chris.diamand at foss.arm.com> wrote:

> > +/**
> > + * struct drm_panthor_group_submit - Arguments passed to DRM_IOCTL_PANTHOR_VM_BIND
> > + */
> > +struct drm_panthor_group_submit {
> > +	/** @group_handle: Handle of the group to queue jobs to. */
> > +	__u32 group_handle;
> > +
> > +	/** @pad: MBZ. */
> > +	__u32 pad;
> > +
> > +	/** @queue_submits: Array of drm_panthor_queue_submit objects. */
> > +	struct drm_panthor_obj_array queue_submits;
> > +};  
> 
> 
> Hi! Very minor nit - but shouldn't the comment above say DRM_IOCTL_PANTHOR_GROUP_SUBMIT, not VM_BIND?

Certainly, I'll fix it in v4.


More information about the dri-devel mailing list