[PATCH v2 1/2] dt-bindings: backlight: Add Texas Instruments LM3509

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Sat Mar 9 12:22:28 UTC 2024


On 09/03/2024 13:09, Patrick Gansterer wrote:
> On 09/03/2024 12:53, Krzysztof Kozlowski wrote:
>>> +  - compatible
>>> +  - reg
>>> +
>>> +patternProperties:
>>> +  "^led@[01]$":
>>> +    type: object
>>> +    description: Properties for a string of connected LEDs.
>>
>> Are you sure this is a string of LEDs? How does a string/tape work with
>> a backlight, I mean physically? How could it look like?
> 
> I just took most of the descriptions/names from lm3630a-backlight.yaml. 
> I understand it in this context as multiple serial connected LEDs (as 
> shown in the circuit diagram in the datasheet), so that each of them 
> gets the same current when connected to the output of the chip.
> 

lm3630 might have copied it as well. LED strings are true in case of...
well, LED strings, but I just wonder if such setup is applicable for
backlight. Anyway, if you think it is, I don't mind.


> Maybe a more general question: Is there any easy accessible information 
> about which code is the best used as example/reference? I tried to align 
> my code very close to the LM3630, but you gave me a bunch of comments on 
> that ;-). And would you like see patches cleaning up some of the code 
> with bad/outdated style?

There is no such reference, except example-schema. Usually newest
bindings, which passed review, are the best source.

Best regards,
Krzysztof



More information about the dri-devel mailing list