[PATCH 3/5] drm/i915: Update IP_VER(12, 50)

Lucas De Marchi lucas.demarchi at intel.com
Mon Mar 11 15:29:45 UTC 2024


On Mon, Mar 11, 2024 at 11:18:03AM -0400, Rodrigo Vivi wrote:
>On Wed, Mar 06, 2024 at 11:36:41AM -0800, Lucas De Marchi wrote:
>> With no platform declaring graphics/media IP_VER(12, 50),
>
>this is not true.
>We still have
>
>#define XE_HPM_FEATURES \
>	.__runtime.media.ip.ver = 12, \
>        .__runtime.media.ip.rel = 50

<snip>

>> -#define XE_HPM_FEATURES \
>> -	.__runtime.media.ip.ver = 12, \
>> -	.__runtime.media.ip.rel = 50
>> -

^ being removed here since all the users, like below, are overriding it.

>>  #define DG2_FEATURES \
>>  	XE_HP_FEATURES, \
>> -	XE_HPM_FEATURES, \
>>  	DGFX_FEATURES, \
>> +	.__runtime.graphics.ip.ver = 12, \
>>  	.__runtime.graphics.ip.rel = 55, \
>> +	.__runtime.media.ip.ver = 12, \
>>  	.__runtime.media.ip.rel = 55, \

				  ^^

After applying until this patch:

$ git grep -e "rel[[:space:]]*=" -- drivers/gpu/drm/i915/i915_pci.c
drivers/gpu/drm/i915/i915_pci.c:        .__runtime.graphics.ip.rel = 10,
drivers/gpu/drm/i915/i915_pci.c:        .__runtime.graphics.ip.rel = 55, \
drivers/gpu/drm/i915/i915_pci.c:        .__runtime.media.ip.rel = 55, \
drivers/gpu/drm/i915/i915_pci.c:        .__runtime.graphics.ip.rel = 60,
drivers/gpu/drm/i915/i915_pci.c:        .__runtime.media.ip.rel = 60,
drivers/gpu/drm/i915/i915_pci.c:        .__runtime.graphics.ip.rel = 70,

should I reword anything in the commit message to make my intent
clearer?

thanks
Lucas De Marchi


More information about the dri-devel mailing list