[PATCH] backlight: mp3309c: fix signedness bug in mp3309c_parse_fwnode()

FLAVIO SULIGOI f.suligoi at asem.it
Mon Mar 18 11:18:20 UTC 2024


Hi Dan,

> The "num_levels" variable is used to store error codes from
> device_property_count_u32() so it needs to be signed.  This doesn't cause an
> issue at runtime because devm_kcalloc() won't allocate negative sizes.
> However, it's still worth fixing.
> 
> Fixes: b54c828bdba9 ("backlight: mp3309c: Make use of device properties")
> Signed-off-by: Dan Carpenter <dan.carpenter at linaro.org>

I've just tested on my board with the mp3309c chip, all is ok.
Thanks!

Tested-by: Flavio Suligoi <f.suligoi at asem.it>



More information about the dri-devel mailing list