<div class="gmail_quote">On Thu, Mar 29, 2012 at 18:28, Paulo Zanoni <span dir="ltr"><<a href="mailto:przanoni@gmail.com">przanoni@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> From: Paulo Zanoni <<a href="mailto:paulo.r.zanoni@intel.com">paulo.r.zanoni@intel.com</a>><br> <br> In the future we'll have more than just connector properties, so create<br> a dump_prop function that can handle any property (instead of the<br> current dump_props function that only handles connector properties).<br> <br> Also, make this function print a lot more information about the existing<br> properties.<br> <br> Also change the printed indentation of the modes to make the output more<br> readable.<br></blockquote><div><br></div><div><really-small-bikeshedding></div><div>I don't know if it should go into a separate patch though. But it is aligned to the other formatting patterns you do, and it certainly looks nicer this way, and it shouldn't break anything anyway. So I am fine either way :).</div> <div></really-small-bikeshedding></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> The previous function dump_props also segfaulted when we didn't have<br> enought permissions. The new function does not segfault in this case (by<br> checking for the return value of drmModeGetProperty).<br></blockquote><div><br></div><div><another-bikeshedding></div><div>I think this could be done in a separate patch..</div><div></another-bikeshedding></div> <div><br></div><div>But besides those comments, this is:</div><div><br></div><div>Reviewed-by: Eugeni Dodonov <<a href="mailto:eugeni.dodonov@intel.com">eugeni.dodonov@intel.com</a>></div><div><br></div></div>-- <br> Eugeni Dodonov<a href="http://eugeni.dodonov.net/" target="_blank"><br></a><br>