<div class="gmail_quote">On Thu, Mar 29, 2012 at 18:28, Paulo Zanoni <span dir="ltr"><<a href="mailto:przanoni@gmail.com" target="_blank">przanoni@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> From: Paulo Zanoni <<a href="mailto:paulo.r.zanoni@intel.com" target="_blank">paulo.r.zanoni@intel.com</a>><br> <br> Use unsigned int instead of int:<br> - modetest.c:89:1: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]<br> - modetest.c:97:1: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]<br> - modetest.c:117:1: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]<br> - modetest.c:772:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]<br> <br> The 'fd' variable is global, we don't need to pass it as an argument:<br> - modetest.c:698:40: warning: unused parameter ‘fd’ [-Wunused-parameter]<br> <br> We don't use the 'modeset' variable:<br> - modetest.c:725:8: warning: variable ‘modeset’ set but not used [-Wunused-but-set-variable]<br></blockquote><div><br></div><div>This one is:</div><div>Reviewed-by: Eugeni Dodonov <<a href="mailto:eugeni.dodonov@intel.com" target="_blank">eugeni.dodonov@intel.com</a>></div> <div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">-static int page_flipping_supported(int fd)<br> +static int page_flipping_supported(void)<br></blockquote><div><br></div><div>I wonder if we could drop the dead^W#ifd 0'ed code here as well, perhaps with a separate patch? I don't think it will get used again in the future (but I might be wrong).</div> <div><br></div></div>-- <br>Eugeni Dodonov<a href="http://eugeni.dodonov.net/" target="_blank"><br></a><br>