+ V4L2 develper Sylwester, please give your opinions? How to handle it at v4l2 side. Thank you, Kyungmin Park <div class="gmail_quote">On Apr 6, 2012 12:44 AM, "Ville Syrjälä" <<a href="mailto:syrjala@sci.fi">syrjala@sci.fi</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> On Fri, Apr 06, 2012 at 03:05:36PM +0900, Inki Dae wrote: > Hi Ville, > > > -----Original Message----- > > From: Ville Syrjälä [mailto:<a href="mailto:ville.syrjala@linux.intel.com">ville.syrjala@linux.intel.com</a>] > > Sent: Friday, April 06, 2012 3:14 AM > > To: <a href="mailto:airlied@redhat.com">airlied@redhat.com</a> > > Cc: <a href="mailto:inki.dae@samsung.com">inki.dae@samsung.com</a>; <a href="mailto:kyungmin.park@samsung.com">kyungmin.park@samsung.com</a>; dri- > > <a href="mailto:devel@lists.freedesktop.org">devel@lists.freedesktop.org</a>; Seung-Woo Kim > > Subject: Re: [PATCH libdrm] libdrm: update drm/drm_fourcc.h from kernel to > > add multi plane formats > > > > On Fri, Mar 30, 2012 at 01:12:58PM +0300, Ville Syrjälä wrote: > > > On Fri, Mar 30, 2012 at 11:54:50AM +0900, Seung-Woo Kim wrote: > > > > Multi buffer plane pixel formats are added as like kernel header. > > > > > > > > Signed-off-by: Seung-Woo Kim <<a href="mailto:sw0312.kim@samsung.com">sw0312.kim@samsung.com</a>> > > > > --- > > > > include/drm/drm_fourcc.h | 7 +++++++ > > > > 1 files changed, 7 insertions(+), 0 deletions(-) > > > > > > > > diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h > > > > index 85facb0..7cfd95a 100644 > > > > --- a/include/drm/drm_fourcc.h > > > > +++ b/include/drm/drm_fourcc.h > > > > @@ -107,6 +107,10 @@ > > > > #define DRM_FORMAT_NV16 fourcc_code('N', 'V', '1', '6') /* > > 2x1 subsampled Cr:Cb plane */ > > > > #define DRM_FORMAT_NV61 fourcc_code('N', 'V', '6', '1') /* > > 2x1 subsampled Cb:Cr plane */ > > > > > > > > +/* 2 non contiguous plane YCbCr */ > > > > +#define DRM_FORMAT_NV12M fourcc_code('N', 'M', '1', '2') /* 2x2 > > subsampled Cr:Cb plane */ > > > > > > NAK. DRM_FORMAT_NV12 handles this just fine. > > > > And I just realized that I was already too late with my NAK since this a > > libdrm patch. Apparently the kernel drm_fourcc.h changes were snuck in > > via some backdoor without review. Sigh. > > > > We had already requested review for it. for this you can refer to link > below: > > <a href="http://lists.freedesktop.org/archives/dri-devel/2011-December/017654.html" target="_blank">http://lists.freedesktop.org/archives/dri-devel/2011-December/017654.html</a> I see. I couldn't find it in my work mailbox for some reason, and I don't remember having seen the patch before. I suppose I just missed it due to Christmas vacations, and was too blind to see it in my mailbox. Also google decicded to filter my search results too much, so I didn't spot it via the web archives either. I'm sorry for the false accusation. > > So they're now in Linus's tree. But looks like format_check() was never > > updated to accept them, so there's no way anyone could actually be using > > them. So Dave, can we still remove them from the kernel header? > > > > Yes, right. these formats aren't used for any SoCs except Exynos series yet > but just we are first. I think they should be added because anyone may use > them someday at least possible. Since DRM_FORMAT_NV12M is _identical_ to DRM_FORMAT_NV12, I see no point in adding it (similarly for YUV420M vs. YUV420). -- Ville Syrjälä <a href="mailto:syrjala@sci.fi">syrjala@sci.fi</a> <a href="http://www.sci.fi/~syrjala/" target="_blank">http://www.sci.fi/~syrjala/</a> _______________________________________________ dri-devel mailing list <a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a> </blockquote></div>