Hello,<br><br><div class="gmail_quote">On Thu, Aug 23, 2012 at 2:52 AM, 김승우 <span dir="ltr"><<a href="mailto:sw0312.kim@samsung.com" target="_blank">sw0312.kim@samsung.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Hi Daniel,<br> <div class="im"><br> On 2012년 08월 23일 17:50, Daniel Vetter wrote:<br> > On Wed, Aug 22, 2012 at 06:53:33PM +0530, Shirish S wrote:<br> >> From: Shirish Shankarappa <<a href="mailto:s.shirish@samsung.com">s.shirish@samsung.com</a>><br> >><br> >> The value of MAX_EDID is now valid only for 2<br> >> block EDID data which is 256, but to support<br> >> 4 block EDID (E-DDC) this needs to be 512.<br> >><br> >> Signed-off-by: Shirish Shankarappa <<a href="mailto:s.shirish@samsung.com">s.shirish@samsung.com</a>><br> >> ---<br> >> drivers/gpu/drm/exynos/exynos_drm_connector.c | 2 +-<br> >> 1 files changed, 1 insertions(+), 1 deletions(-)<br> >><br> >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c b/drivers/gpu/drm/exynos/exynos_drm_connector.c<br> >> index d956819..69d02b5 100644<br> >> --- a/drivers/gpu/drm/exynos/exynos_drm_connector.c<br> >> +++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c<br> >> @@ -32,7 +32,7 @@<br> >> #include "exynos_drm_drv.h"<br> >> #include "exynos_drm_encoder.h"<br> >><br> >> -#define MAX_EDID 256<br> >> +#define MAX_EDID 512<br> >> #define to_exynos_connector(x) container_of(x, struct exynos_drm_connector,\<br> >> drm_connector)<br> ><br> > Shouldn't this be in a common drm/edid header to begin with?<br> <br> </div>This value is not real maximum length of EDID and it is only used for<br> memory allocation by exynos connector. Actually, this allocation is<br> unnecessary because edid is already allocated by drm_get_edid().<br> <br> So, I have plan to remove this allocation and the definition once Jani<br> Nikula's patches for removing raw_edid related memory leaks are applied.<br> <br></blockquote><div>I was not aware of your plans to remove it, anyways for verifying the patch for 4 block EDID data,</div><div>this modification is required,hence i thought of posting this patch.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> > -Daniel<br> ><br> <br> Thanks and Regards,<br> - Seung-Woo Kim<br> <span class="HOEnZb"><font color="#888888"><br> <br> --<br> Seung-Woo Kim<br> Samsung Software R&D Center<br> --<br> </font></span><div class="HOEnZb"><div class="h5"><br></div></div></blockquote><div>Thanks& Regards,</div><div>Shirish S </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div class="HOEnZb"><div class="h5"> _______________________________________________<br> dri-devel mailing list<br> <a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br> <a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br> </div></div></blockquote></div><br>