<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - [bisected] kernel 3.7.0-rc1 breaks 6950 (CAYMAN)" href="https://bugs.freedesktop.org/show_bug.cgi?id=56139#c6">Comment # 6</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - [bisected] kernel 3.7.0-rc1 breaks 6950 (CAYMAN)" href="https://bugs.freedesktop.org/show_bug.cgi?id=56139">bug 56139</a> from <a class="email" href="mailto:alexandre.f.demers@gmail.com" title="Alexandre Demers <alexandre.f.demers@gmail.com>"> Alexandre Demers</a> <pre>(In reply to <a href="show_bug.cgi?id=56139#c5">comment #5</a>) > Created <a href="attachment.cgi?id=69113" name="attach_69113" title="possible fix">attachment 69113</a> <a href="attachment.cgi?id=69113&action=edit" title="possible fix">[details]</a> <a href='page.cgi?id=splinter.html&bug=56139&attachment=69113'>[review]</a> [review] > possible fix > > (In reply to <a href="show_bug.cgi?id=56139#c4">comment #4</a>) > > the bug appeared. So it seems blanking the display controllers with for(i = > > 0; i < rdev->num_crtc; i++) is not equivalent to the code that it replaces. > > The original code first wrote in the EVERGREEN_CRTC_UPDATE_LOCK registers, > > before setting EVERGREEN_CRTC_CONTROL registers and writing again in the > > EVERGREEN_CRTC_UPDATE_LOCK registers. On the other hand, the new code > > doesn't write in the EVERGREEN_CRTC_UPDATE_LOCK neither before nor after > > setting EVERGREEN_CRTC_CONTROL. > > It should be equivalent. CRTC_UPDATE_LOCK turns off double buffering in the > crtc which makes register updates atomic. The new code waits for the frame > count to increase (the double buffered updates happen at vblank) so it > should be equivalent. That said, it shouldn't hurt to take the lock. Does > this patch help? Sadly, it didn't help.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>