Applied. And it seems like that another one needs some review So will let me pick it up later after review.<br><br>Thanks,<br>Inki Dae<br><br><div class="gmail_quote">2012/11/8 Inki Dae <span dir="ltr"><<a href="mailto:inki.dae@samsung.com" target="_blank">inki.dae@samsung.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br><br><div class="gmail_quote"><div class="im">2012/11/7 Prathyush K <span dir="ltr"><<a href="mailto:prathyush.k@samsung.com" target="_blank">prathyush.k@samsung.com</a>></span><br>
<blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
The function dma_get_sgtable will allocate a sg table internally so<br>
it is not necessary to allocate a sg table before it. The unnecessary<br>
'sg_alloc_table' call is removed.<br>
<br>
Signed-off-by: Prathyush K <<a href="mailto:prathyush.k@samsung.com" target="_blank">prathyush.k@samsung.com</a>><br>
---<br>
drivers/gpu/drm/exynos/exynos_drm_dmabuf.c | 8 +-------<br>
1 files changed, 1 insertions(+), 7 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dmabuf.c b/drivers/gpu/drm/exynos/exynos_drm_dmabuf.c<br>
index b98da30..d9307bd 100644<br>
--- a/drivers/gpu/drm/exynos/exynos_drm_dmabuf.c<br>
+++ b/drivers/gpu/drm/exynos/exynos_drm_dmabuf.c<br>
@@ -40,21 +40,15 @@ static struct sg_table *exynos_get_sgt(struct drm_device *drm_dev,<br>
if (!sgt)<br>
goto out;<br>
<br>
- ret = sg_alloc_table(sgt, buf->sgt->nents, GFP_KERNEL);<br>
- if (ret)<br>
- goto err_free_sgt;<br>
-<br></blockquote><div> </div></div><div>It's good catch. Right, I missed it. dma_get_sgtable function also calls sg_alloc_table.</div><div class="im"><div> </div><blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
ret = dma_get_sgtable(drm_dev->dev, sgt, buf->kvaddr,<br>
buf->dma_addr, buf->size);<br>
if (ret < 0) {<br>
DRM_ERROR("failed to get sgtable.\n");<br>
- goto err_free_table;<br>
+ goto err_free_sgt;<br>
}<br>
<br>
return sgt;<br>
<br>
-err_free_table:<br>
- sg_free_table(sgt);<br>
err_free_sgt:<br>
kfree(sgt);<br>
sgt = NULL;<br>
<span><font color="#888888">--<br>
1.7.0.4<br>
<br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org" target="_blank">dri-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</font></span></blockquote></div></div><br>
</blockquote></div><br>