<br><br><div class="gmail_quote">2012/11/7 Imre Deak <span dir="ltr"><<a href="mailto:imre.deak@intel.com" target="_blank">imre.deak@intel.com</a>></span><br><blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
<div class="im">On Wed, 2012-11-07 at 18:31 +0900, Inki Dae wrote:<br>
> 2012/11/2 Imre Deak <<a href="mailto:imre.deak@intel.com">imre.deak@intel.com</a>><br>
> The patchset adds the missing event_lock when accessing the<br>
> vblank_event_list in drm_vblank_off() and as preparation for<br>
> this<br>
> also fixes a few other issues in the exynos driver.<br>
> This is also a dependency for Rob Clark's<br>
> drm_send_vblank_event()<br>
> rework as that would trigger a warning for the unhold<br>
> event_lock without<br>
> this changeset.<br>
> The exynos changes are only compile tested, the rest is tested<br>
> on an<br>
> Intel IVB machine on top of drm-intel-nightly +<br>
> drm_send_vblank_event()<br>
> rework, with i-g-t/flip_test.<br>
> Hi Imre,<br>
> Works fine. But we should wait for Rob's patch set to be merged to<br>
> -next, and this may be rebased on top of latest Rob's patch set again.<br>
<br>
</div>Ok, thanks for checking this. I assume then that this patchset will get<br>
merged through your tree.<br>
<br>
I think Rob's patchset depends on this, so ideally this should go first.<br>
Otherwise the i915 driver would trigger the WARN in his patchset due to<br>
the unheld event_lock.<br></blockquote><div> </div><div>Ok, but I merge it first, shouldn't Rob's patch set be rebased? Anyway this is minor issue so I could resolve it. And it seems like that your patch set has no dependency of Rob's. I mean that your patch set worked fine without Rob's.</div>
<div> </div><div>Thanks,</div><div>Inki Dae</div><div> </div><blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
<span class="HOEnZb"><font color="#888888"><br>
--Imre<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</div></div></blockquote></div><br>