Applied.<br><br>Thanks,<br>Inki Dae<br><br><div class="gmail_quote">2012/12/7 Wei Yongjun <span dir="ltr"><<a href="mailto:weiyj.lk@gmail.com" target="_blank">weiyj.lk@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
From: Wei Yongjun <<a href="mailto:yongjun_wei@trendmicro.com.cn">yongjun_wei@trendmicro.com.cn</a>><br>
<br>
In case of error, function arm_iommu_create_mapping() returns<br>
ERR_PTR() and never returns NULL. The NULL test in the return<br>
value check should be replaced with IS_ERR().<br>
<br>
Signed-off-by: Wei Yongjun <<a href="mailto:yongjun_wei@trendmicro.com.cn">yongjun_wei@trendmicro.com.cn</a>><br>
---<br>
 drivers/gpu/drm/exynos/exynos_drm_iommu.c | 2 +-<br>
 1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.c b/drivers/gpu/drm/exynos/exynos_drm_iommu.c<br>
index 09db198..3b3d3a6 100644<br>
--- a/drivers/gpu/drm/exynos/exynos_drm_iommu.c<br>
+++ b/drivers/gpu/drm/exynos/exynos_drm_iommu.c<br>
@@ -56,7 +56,7 @@ int drm_create_iommu_mapping(struct drm_device *drm_dev)<br>
        mapping = arm_iommu_create_mapping(&platform_bus_type, priv->da_start,<br>
                                                priv->da_space_size,<br>
                                                priv->da_space_order);<br>
-       if (!mapping)<br>
+       if (IS_ERR(mapping))<br>
                return -ENOMEM;<br>
<br>
        dev->dma_parms = devm_kzalloc(dev, sizeof(*dev->dma_parms),<br>
<br>
<br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</blockquote></div><br>