<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:sroland@vmware.com" title="Roland Scheidegger <sroland@vmware.com>"> <span class="fn">Roland Scheidegger</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [KMS] mesa demo spectex broken on rv280"
href="https://bugs.freedesktop.org/show_bug.cgi?id=22576">bug 22576</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>REOPENED
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [KMS] mesa demo spectex broken on rv280"
href="https://bugs.freedesktop.org/show_bug.cgi?id=22576#c21">Comment # 21</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [KMS] mesa demo spectex broken on rv280"
href="https://bugs.freedesktop.org/show_bug.cgi?id=22576">bug 22576</a>
from <span class="vcard"><a class="email" href="mailto:sroland@vmware.com" title="Roland Scheidegger <sroland@vmware.com>"> <span class="fn">Roland Scheidegger</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=22576#c18">comment #18</a>)
<span class="quote">> I think i've found source of these lighting problems on r200 in this and
> other bugs. It is just a typo it seems in r200_state_init.c lit_emit()
>
> OUT_VEC(atom->cmd[LIT_CMD_1], atom->cmd+LIT_CMD_1+1);
>
> instead of OUT_VEC it needs to be OUT_SCL:
>
> OUT_SCL(atom->cmd[LIT_CMD_1], atom->cmd+LIT_CMD_1+1);</span >
Should be fixed by 320d531373e7b0873f5de42f6173b986290f593f, thanks!
FWIW the command emit mechanism looks a bit too complicated it could profit
from some refactoring. For instance it is still based on the fake
drm_radeon_cmd_header_t structure, the scl vs. scl2 and vec vs. veclinear emits
are nothing but crude hacks around limitations in that structure, even though
since ums is gone there is absolutely no point in using that struct...
Section size calcs are also somewhat confusing, the sanity code (which was
really great back then) is totally unused etc.
Maybe another day...</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>