<div dir="ltr">Hi,<div><br></div><div>Please review this patch.</div><div><br></div><div style>Regards,</div><div style>Prathyush</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Dec 27, 2012 at 5:10 PM, Prathyush K <span dir="ltr"><<a href="mailto:prathyush.k@samsung.com" target="_blank">prathyush.k@samsung.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">If fimd is runtime suspended (by DPMS OFF), fimd_suspend does not<br>
call fimd_activate(false) and just returns. Similarily the check in<br>
fimd_resume should not resume if previously runtime_suspended.<br>
Instead the existing check does the opposite. So if fimd was not<br>
runtime suspended, suspend will turn off fimd but resume will not turn<br>
it on.  This patch fixes this issue by reversing the condition.<br>
<br>
Signed-off-by: Prathyush K <<a href="mailto:prathyush.k@samsung.com">prathyush.k@samsung.com</a>><br>
---<br>
 drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +-<br>
 1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c<br>
index bf0d9ba..9accd466 100644<br>
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c<br>
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c<br>
@@ -1046,7 +1046,7 @@ static int fimd_resume(struct device *dev)<br>
         * of pm runtime would still be 1 so in this case, fimd driver<br>
         * should be on directly not drawing on pm runtime interface.<br>
         */<br>
-       if (pm_runtime_suspended(dev)) {<br>
+       if (!pm_runtime_suspended(dev)) {<br>
                int ret;<br>
<br>
                ret = fimd_activate(ctx, true);<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.8.0<br>
<br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</font></span></blockquote></div><br></div>