<br><br><div class="gmail_quote">On Wed, Jan 23, 2013 at 8:18 PM, Sean Paul <span dir="ltr"><<a href="mailto:seanpaul@chromium.org" target="_blank">seanpaul@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Wed, Jan 23, 2013 at 5:10 AM, Shirish S <<a href="mailto:s.shirish@samsung.com">s.shirish@samsung.com</a>> wrote:<br>
> The hdmi and mixer win_commit calls currently are<br>
> not checking the status of IP before updating the<br>
> respective registers, this patch adds this check.<br>
><br>
> Signed-off-by: Shirish S <<a href="mailto:s.shirish@samsung.com">s.shirish@samsung.com</a>><br>
> ---<br>
>  drivers/gpu/drm/exynos/exynos_hdmi.c  | 3 +++<br>
>  drivers/gpu/drm/exynos/exynos_mixer.c | 3 +++<br>
>  2 files changed, 6 insertions(+)<br>
><br>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c<br>
> index 2c46b6c..ae79688 100644<br>
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c<br>
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c<br>
> @@ -2170,6 +2170,9 @@ static void hdmi_commit(void *ctx)<br>
><br>
>         DRM_DEBUG_KMS("[%d] %s\n", __LINE__, __func__);<br>
><br>
> +       if (!hdata->powered)<br>
<br>
</div>The rest of the driver protects reads & writes to powered with hdmi_mutex<br>
<div class="im"><br>
> +               return;<br>
> +<br>
>         hdmi_conf_apply(hdata);<br>
>  }<br>
><br>
> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c<br>
> index 21db895..4f5433f 100644<br>
> --- a/drivers/gpu/drm/exynos/exynos_mixer.c<br>
> +++ b/drivers/gpu/drm/exynos/exynos_mixer.c<br>
> @@ -775,6 +775,9 @@ static void mixer_win_commit(void *ctx, int win)<br>
><br>
>         DRM_DEBUG_KMS("[%d] %s, win: %d\n", __LINE__, __func__, win);<br>
><br>
> +       if (!mixer_ctx->powered)<br>
<br>
</div>This is also protected everywhere else in the driver.<br>
<div class="HOEnZb"><div class="h5"><br></div></div></blockquote><div>Thanks Sean, have uploaded patch set 2. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb">
<div class="h5">
> +               return;<br>
> +<br>
>         if (win > 1 && mixer_ctx->vp_enabled)<br>
>                 vp_video_buffer(mixer_ctx, win);<br>
>         else<br>
> --<br>
> 1.8.0<br>
><br>
> _______________________________________________<br>
> dri-devel mailing list<br>
> <a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</div></div></blockquote></div><br><div>Regards,</div><div>Shirish S</div>