<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Corruption with DMA ring on cayman" href="https://bugs.freedesktop.org/show_bug.cgi?id=60802#c54">Comment # 54</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - Corruption with DMA ring on cayman" href="https://bugs.freedesktop.org/show_bug.cgi?id=60802">bug 60802</a> from <a class="email" href="mailto:alexandre.f.demers@gmail.com" title="Alexandre Demers <alexandre.f.demers@gmail.com>"> Alexandre Demers</a> <pre>(In reply to <a href="show_bug.cgi?id=60802#c51">comment #51</a>) > Created <a href="attachment.cgi?id=76544" name="attach_76544" title="set non_disp tiling bit for cayman">attachment 76544</a> <a href="attachment.cgi?id=76544&action=edit" title="set non_disp tiling bit for cayman">[details]</a> <a href='page.cgi?id=splinter.html&bug=60802&attachment=76544'>[review]</a> [review] > set non_disp tiling bit for cayman > > Good catch! I believe the attached patch should fix the issue. Since this bug is pretty much the same as previous one I had identified in <a href="show_bug.cgi?id=60802#c29">comment 29</a> (pointing to <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - DXT3 and DXT5 broken on Cayman gpu" href="show_bug.cgi?id=38173">bug 38173</a>) and since the proposed patch is also pretty similar to 1 of the 2 patches needed to fix that identified bug, is it possible there is something missing that would look like the second patch that was needed? patch 1 from <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - DXT3 and DXT5 broken on Cayman gpu" href="show_bug.cgi?id=38173">bug 38173</a> (similar to the one proposed with your <a href="attachment.cgi?id=76544" name="attach_76544" title="set non_disp tiling bit for cayman">attachment 76544</a> <a href="attachment.cgi?id=76544&action=edit" title="set non_disp tiling bit for cayman">[details]</a> <a href='page.cgi?id=splinter.html&bug=60802&attachment=76544'>[review]</a>): <a href="http://cgit.freedesktop.org/mesa/mesa/commit/?id=5e1495b2d9311fa2b320766a1d299053904bd9c3">http://cgit.freedesktop.org/mesa/mesa/commit/?id=5e1495b2d9311fa2b320766a1d299053904bd9c3</a> patch 2 from <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - DXT3 and DXT5 broken on Cayman gpu" href="show_bug.cgi?id=38173">bug 38173</a> (possibly similar to what is missing to complete your proposed patch): <a href="http://cgit.freedesktop.org/mesa/mesa/commit/?id=acca690c259824636ef1ff684a10bd1caca4751f">http://cgit.freedesktop.org/mesa/mesa/commit/?id=acca690c259824636ef1ff684a10bd1caca4751f</a> In other words, are we sure we are offsetting the non_disp variable correctly for Cayman? Because according to the second patch, the offset was different.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>