<div dir="ltr"><div><div>Hi, Dave<br><br></div>Why this patch hasn't been applied in your tree? I think you are the right maintainer.<br><br></div>Huacai Chen<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Tue, May 21, 2013 at 11:30 PM, Paul Menzel <span dir="ltr"><<a href="mailto:paulepanter@users.sourceforge.net" target="_blank">paulepanter@users.sourceforge.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Am Dienstag, den 21.05.2013, 14:23 +0800 schrieb Huacai Chen:<br>
<div><div class="h5">> When GPU acceleration is disabled, drm_vblank_cleanup() will free the<br>
> vblank-related data, such as vblank_refcount, vblank_inmodeset, etc.<br>
> But we found that drm_vblank_post_modeset() may be called after the<br>
> cleanup, which use vblank_refcount and vblank_inmodeset. And this will<br>
> cause a kernel panic.<br>
><br>
> Fix this by return immediately if dev->num_crtcs is zero. This is the<br>
> same thing that drm_vblank_pre_modeset() does.<br>
><br>
> Call trace of a drm_vblank_post_modeset() after drm_vblank_cleanup():<br>
> [ 62.628906] [<ffffffff804868d0>] drm_vblank_post_modeset+0x34/0xb4<br>
> [ 62.628906] [<ffffffff804c7008>] atombios_crtc_dpms+0xb4/0x174<br>
> [ 62.628906] [<ffffffff804c70e0>] atombios_crtc_commit+0x18/0x38<br>
> [ 62.628906] [<ffffffff8047f038>] drm_crtc_helper_set_mode+0x304/0x3cc<br>
> [ 62.628906] [<ffffffff8047f92c>] drm_crtc_helper_set_config+0x6d8/0x988<br>
> [ 62.628906] [<ffffffff8047dd40>] drm_fb_helper_set_par+0x94/0x104<br>
> [ 62.628906] [<ffffffff80439d14>] fbcon_init+0x424/0x57c<br>
> [ 62.628906] [<ffffffff8046a638>] visual_init+0xb8/0x118<br>
> [ 62.628906] [<ffffffff8046b9f8>] take_over_console+0x238/0x384<br>
> [ 62.628906] [<ffffffff80436df8>] fbcon_takeover+0x7c/0xdc<br>
> [ 62.628906] [<ffffffff8024fa20>] notifier_call_chain+0x44/0x94<br>
> [ 62.628906] [<ffffffff8024fcbc>] __blocking_notifier_call_chain+0x48/0x68<br>
> [ 62.628906] [<ffffffff8042d990>] register_framebuffer+0x228/0x260<br>
> [ 62.628906] [<ffffffff8047e010>] drm_fb_helper_single_fb_probe+0x260/0x314<br>
> [ 62.628906] [<ffffffff8047e2c4>] drm_fb_helper_initial_config+0x200/0x234<br>
> [ 62.628906] [<ffffffff804e5560>] radeon_fbdev_init+0xd4/0xf4<br>
> [ 62.628906] [<ffffffff804e0e08>] radeon_modeset_init+0x9bc/0xa18<br>
> [ 62.628906] [<ffffffff804bfc14>] radeon_driver_load_kms+0xdc/0x12c<br>
> [ 62.628906] [<ffffffff8048b548>] drm_get_pci_dev+0x148/0x238<br>
> [ 62.628906] [<ffffffff80423564>] local_pci_probe+0x5c/0xd0<br>
> [ 62.628906] [<ffffffff80241ac4>] work_for_cpu_fn+0x1c/0x30<br>
> [ 62.628906] [<ffffffff802427c8>] process_one_work+0x274/0x3bc<br>
> [ 62.628906] [<ffffffff80242934>] process_scheduled_works+0x24/0x44<br>
> [ 62.628906] [<ffffffff8024515c>] worker_thread+0x31c/0x3f4<br>
> [ 62.628906] [<ffffffff802497a8>] kthread+0x88/0x90<br>
> [ 62.628906] [<ffffffff80206794>] kernel_thread_helper+0x10/0x18<br>
<br>
</div></div>Nice commit message!<br>
<div class="im"><br>
> Signed-off-by: Huacai Chen <<a href="mailto:chenhc@lemote.com">chenhc@lemote.com</a>><br>
> Signed-off-by: Binbin Zhou <<a href="mailto:zhoubb@lemote.com">zhoubb@lemote.com</a>><br>
> Cc: <<a href="mailto:stable@vger.kernel.org">stable@vger.kernel.org</a>><br>
> ---<br>
> drivers/gpu/drm/drm_irq.c | 6 +++++-<br>
> 1 files changed, 5 insertions(+), 1 deletions(-)<br>
<br>
</div>[…]<br>
<br>
Acked-by: Paul Menzel <<a href="mailto:paulepanter@users.sourceforge.net">paulepanter@users.sourceforge.net</a>><br>
<br>
<br>
Thanks,<br>
<br>
Paul<br>
<br>_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
<br></blockquote></div><br></div>