<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - bug in r300 compiler" href="https://bugs.freedesktop.org/show_bug.cgi?id=54867#c2">Comment # 2</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - bug in r300 compiler" href="https://bugs.freedesktop.org/show_bug.cgi?id=54867">bug 54867</a> from <a class="email" href="mailto:tstellar@gmail.com" title="Tom Stellard <tstellar@gmail.com>"> Tom Stellard</a> <pre>Comment on <a href="attachment.cgi?id=80074" name="attach_80074" title="s/signed/int/">attachment 80074</a> <a href="attachment.cgi?id=80074&action=edit" title="s/signed/int/">[details]</a> <a href='page.cgi?id=splinter.html&bug=54867&attachment=80074'>[review]</a> s/signed/int/ Review of <a href="attachment.cgi?id=80074" name="attach_80074" title="s/signed/int/">attachment 80074</a> <a href="attachment.cgi?id=80074&action=edit" title="s/signed/int/">[details]</a> <a href='page.cgi?id=splinter.html&bug=54867&attachment=80074'>[review]</a>: ----------------------------------------------------------------- This patch looks good to me, but for the commit message, you need to wrap long lines to 80 or fewer characters (I actually wrap to 75, but I'm not sure what the standard convention is) and re-organize the commit message in the form of: Code area: Brief description Long description (if necessary) Link to fixed bugs For this patch, it should be something like: r300g/compiler: Fix unsigned comparison with less than zero rc_find_free_temporary_list() returns signed integer (in case of lack of free temporary registersreturns -1), so new_index in radeon_rename_regs() should be signed. <a class="bz_bug_link bz_status_NEW " title="NEW --- - bug in r300 compiler" href="show_bug.cgi?id=54867">https://bugs.freedesktop.org/show_bug.cgi?id=54867</a></pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>