<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">2013/6/5 Seung-Woo Kim <span dir="ltr"><<a href="mailto:sw0312.kim@samsung.com" target="_blank">sw0312.kim@samsung.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The definition of regulator_bulk_enable is fixed with __must_check<br>
and this causes following build warning.<br>
warning: ignoring return value of 'regulator_bulk_enable',<br>
declared with attribute warn_unused_result<br>
This patch fixes to check return value of the function.<br>
<br>
Signed-off-by: Seung-Woo Kim <<a href="mailto:sw0312.kim@samsung.com">sw0312.kim@samsung.com</a>><br>
---<br>
drivers/gpu/drm/exynos/exynos_hdmi.c | 4 +++-<br>
1 files changed, 3 insertions(+), 1 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c<br>
index 2f78532..f807b13 100644<br>
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c<br>
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c<br>
@@ -1699,7 +1699,9 @@ static void hdmi_poweron(struct hdmi_context *hdata)<br>
<br>
mutex_unlock(&hdata->hdmi_mutex);<br>
<br>
- regulator_bulk_enable(res->regul_count, res->regul_bulk);<br>
+ if (regulator_bulk_enable(res->regul_count, res->regul_bulk))<br>
+ DRM_ERROR("failed to enable regulator bulk\n");<br></blockquote><div><br></div><div>Now it's not error case; having no return type, so just changed it into DRM_DEBUG_KMS. However, we need to add more exception codes to this function later.<br>
<br></div><div>Applied.<br><br></div><div>Thanks,<br>Inki Dae<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+<br>
clk_enable(res->hdmiphy);<br>
clk_enable(res->hdmi);<br>
clk_enable(res->sclk_hdmi);<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.7.4.1<br>
<br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</font></span></blockquote></div><br></div></div>