<p dir="ltr">Dear Daniel,</p>
<p dir="ltr">On Jul 2, 2013 4:19 PM, "Daniel Vetter" <<a href="mailto:daniel.vetter@ffwll.ch">daniel.vetter@ffwll.ch</a>> wrote:<br>
><br>
> In<br>
><br>
> commit da34242e5e0638312130f5bd5d2d277afbc6f806<br>
> Author: YoungJun Cho <<a href="mailto:yj44.cho@samsung.com">yj44.cho@samsung.com</a>><br>
> Date: Wed Jun 26 10:21:42 2013 +0900<br>
><br>
> drm/prime: add return check for dma_buf_fd<br>
><br>
> the failure case handling was fixed up. But in the case when we<br>
> already had the buffer exported it changed the return value:<br>
> Previously we've return 0 on success, now we return the fd.<br>
><br>
> This ABI change has been caught by i-g-t/prime_self_import/with_one_bo.<br>
><br>
> Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=66436">https://bugs.freedesktop.org/show_bug.cgi?id=66436</a><br>
> Cc: YoungJun Cho <<a href="mailto:yj44.cho@samsung.com">yj44.cho@samsung.com</a>><br>
> Cc: Seung-Woo Kim <<a href="mailto:sw0312.kim@samsung.com">sw0312.kim@samsung.com</a>><br>
> Cc: Kyungmin Park <<a href="mailto:kyungmin.park@samsung.com">kyungmin.park@samsung.com</a>><br>
> Tested-by: lu hua <<a href="mailto:huax.lu@intel.com">huax.lu@intel.com</a>><br>
> Signed-off-by: Daniel Vetter <<a href="mailto:daniel.vetter@ffwll.ch">daniel.vetter@ffwll.ch</a>><br>
> ---<br>
> drivers/gpu/drm/drm_prime.c | 7 +++++--<br>
> 1 file changed, 5 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c<br>
> index 52709f2..1e0de41 100644<br>
> --- a/drivers/gpu/drm/drm_prime.c<br>
> +++ b/drivers/gpu/drm/drm_prime.c<br>
> @@ -347,10 +347,13 @@ int drm_gem_prime_handle_to_fd(struct drm_device *dev,<br>
> out_have_obj:<br>
> get_dma_buf(dmabuf);<br>
> ret = dma_buf_fd(dmabuf, flags);<br>
> - if (ret < 0)<br>
> + if (ret < 0) {<br>
> dma_buf_put(dmabuf);<br>
> - else<br>
> + } else {<br>
> *prime_fd = ret;<br>
> + ret = 0;<br>
> + }<br>
> +<br>
> goto out;<br>
><br>
> fail_rm_handle:<br>
> --<br>
> 1.7.10.4<br>
><br>
></p>
<p dir="ltr">Right, that's my mistake.<br>
I'll pay attention from now on!</p>
<p dir="ltr">Thank you & best regards YJ<br>
_______________________________________________<br>
> dri-devel mailing list<br>
> <a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</p>