<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - VDPAU state tracker reports wrong codec level"
href="https://bugs.freedesktop.org/show_bug.cgi?id=67530#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - VDPAU state tracker reports wrong codec level"
href="https://bugs.freedesktop.org/show_bug.cgi?id=67530">bug 67530</a>
from <span class="vcard"><a class="email" href="mailto:deathsimple@vodafone.de" title="Christian König <deathsimple@vodafone.de>"> <span class="fn">Christian König</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=67530#c4">comment #4</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=83741" name="attach_83741" title="use more common defaults for the level">attachment 83741</a> <a href="attachment.cgi?id=83741&action=edit" title="use more common defaults for the level">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=67530&attachment=83741'>[review]</a> [review]
> use more common defaults for the level
>
> This patch adds more common defaults as level. Imho they are likely not
> correct for all the hardware.</span >
Not bad for a first try, but I have some minor comments:
<span class="quote">> return true;
> case PIPE_VIDEO_CAP_SUPPORTS_PROGRESSIVE:
> return true;
>+ case PIPE_VIDEO_CAP_MAX_LEVEL:
>+ switch (profile) {
>+ case PIPE_VIDEO_PROFILE_MPEG1: </span >
The new code has a different indention, the radeon code uses tabs instead of
spaces, please fix.
Additional to that you need to fix all drivers to handle the new CAP, just
"grep -R PIPE_VIDEO_CAP_SUPPORTED src/gallium/drivers" to find all those
places.
With that fixed please send the patch to the mesa maillinglist for review.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>