<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Glamor on r600g crashes Xserver" href="https://bugs.freedesktop.org/show_bug.cgi?id=70088#c7">Comment # 7</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - Glamor on r600g crashes Xserver" href="https://bugs.freedesktop.org/show_bug.cgi?id=70088">bug 70088</a> from <a class="email" href="mailto:ptpzz@yandex.ru" title="Vadim Girlin <ptpzz@yandex.ru>"> Vadim Girlin</a> <pre>Created <a href="attachment.cgi?id=87148" name="attach_87148" title="patch">attachment 87148</a> <a href="attachment.cgi?id=87148&action=edit" title="patch">[details]</a> <a href='page.cgi?id=splinter.html&bug=70088&attachment=87148'>[review]</a> patch This patch should fix this issue. (In reply to <a href="show_bug.cgi?id=70088#c6">comment #6</a>) > It fixes my crash problem. Maybe code needs more checks for null values? > As always my patch is subpar, You shouldn't use it. Checking for null is not enough in this case, it may prevent segfault but generated shader code would be incorrect anyway, when we have null there it means that something is already broken.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>