<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 22 November 2013 05:52, Keith Packard <span dir="ltr"><<a href="mailto:keithp@keithp.com" target="_blank">keithp@keithp.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
While debugging the libdrm duplicate buffer object adventure, I managed to<br>
temporarily understand object lifetimes in the __DRIimage getBuffers path, and<br>
also to compare that to the DRI2 getBuffers path. Here are a couple of small<br>
fixes.<br>
<br>
I haven't looked at the i915 code, but I suspect the first one, and parts of<br>
the second one would apply.<br>
<br>
[PATCH 1/2] i965: Correct check for re-bound buffer in<br>
<br>
The code was attempting to avoid re-creating the miptree when the loader<br>
handed back the same bufffer we already had, but it was confused about how to<br>
tell -- turns out the object actually shared between the loader and the driver<br>
is the BO, not the region. And so, we compare BO pointers to see if the image<br>
buffer needs to have a new miptree.<br>
<br>
[PATCH 2/2] i965: Set fast color clear mcs_state on newly allocated<br>
<br>
Here's a chunk of code that was just missing from the __DRIimage path as a<br>
result of rebasing across some new driver additions.<br>
<br>
Both of these fixes are candidates for 10.0 as they affect the __DRIimage<br>
paths now used by Wayland.<br></blockquote><div><br></div><div>For future reference, patches that are candidates for the latest stable branch should include the line</div><div><br></div><div>Cc: <a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a></div>
<div><br></div><div>in the patch. (see <a href="http://lists.freedesktop.org/archives/mesa-dev/2013-August/042667.html">http://lists.freedesktop.org/archives/mesa-dev/2013-August/042667.html</a>)</div><div><br></div><div>
I've forwarded this email to <a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a>, which should also be sufficient.</div></div></div></div>