<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Mar 12, 2014 at 10:28 PM, Shirish S <span dir="ltr"><<a href="mailto:s.shirish@samsung.com" target="_blank">s.shirish@samsung.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This patch adds support for the below mentioned<br>
pixel clocks in Exynos5250.<br>
Without them, following display modes won’t<br>
be supported:<br>
<br>
71 MHz  - 1280x800@60Hz RB<br>
73.25 MHz       - 800x600@120Hz RB<br>
88.75 MHz       - 1440x900@60Hz RB<br>
115.5 MHz       - 1024x768@120Hz RB<br>
119 MHz         - 1680x1050@60Hz RB<br>
<br>
Signed-off-by: Shirish S <<a href="mailto:s.shirish@samsung.com">s.shirish@samsung.com</a>><br>
---<br>
V2: Incorporated review comments<br>
<br>
 drivers/gpu/drm/exynos/exynos_hdmi.c |   45 ++++++++++++++++++++++++++++++++++<br>
 1 file changed, 45 insertions(+)<br>
<br>
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c<br>
index 12fdf55..406d89d 100644<br>
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c<br>
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c<br>
@@ -304,6 +304,24 @@ static const struct hdmiphy_config hdmiphy_v14_configs[] = {<br>
                },<br>
        },<br>
        {<br>
+               .pixel_clock = 71000000,<br>
+               .conf = {<br>
+                       0x01, 0x91, 0x1e, 0x15, 0x40, 0x3c, 0xce, 0x08,<br>
+                       0x04, 0x20, 0xb2, 0xd8, 0x45, 0xa0, 0xac, 0x80,<br>
+                       0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,<br>
+                       0x54, 0xad, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,<br>
+               },<br>
+       },<br>
+       {<br>
+               .pixel_clock = 73250000,<br>
+               .conf = {<br>
+                       0x01, 0xd1, 0x1f, 0x15, 0x40, 0x18, 0xe9, 0x08,<br>
+                       0x02, 0xa0, 0xb7, 0xd8, 0x45, 0xa0, 0xac, 0x80,<br>
+                       0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,<br>
+                       0x54, 0xa8, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,<br>
+               },<br>
+       },<br>
+       {<br>
                .pixel_clock = 74176000,<br>
                .conf = {<br>
                        0x01, 0xd1, 0x3e, 0x35, 0x40, 0x5b, 0xde, 0x08,<br>
@@ -331,6 +349,15 @@ static const struct hdmiphy_config hdmiphy_v14_configs[] = {<br>
                },<br>
        },<br>
        {<br>
+               .pixel_clock = 88750000,<br>
+               .conf = {<br>
+                       0x01, 0x91, 0x25, 0x17, 0x40, 0x30, 0xfe, 0x08,<br>
+                       0x06, 0x20, 0xde, 0xd8, 0x45, 0xa0, 0xac, 0x80,<br>
+                       0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,<br>
+                       0x54, 0x8a, 0x24, 0x01, 0x00, 0x00, 0x01, 0x80,<br>
+               },<br>
+       },<br>
+       {<br>
                .pixel_clock = 106500000,<br>
                .conf = {<br>
                        0x01, 0xd1, 0x2c, 0x12, 0x40, 0x0c, 0x09, 0x08,<br>
@@ -349,6 +376,24 @@ static const struct hdmiphy_config hdmiphy_v14_configs[] = {<br>
                },<br>
        },<br>
        {<br>
+               .pixel_clock = 115500000,<br>
+               .conf = {<br>
+                       0x01, 0xd1, 0x30, 0x1a, 0x40, 0x40, 0x10, 0x04,<br>
+                       0x04, 0xa0, 0x21, 0xd9, 0x45, 0xa0, 0xac, 0x80,<br>
+                       0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,<br>
+                       0x54, 0xaa, 0x25, 0x03, 0x00, 0x00, 0x01, 0x80,<br>
+               },<br>
+       },<br>
+       {<br>
+               .pixel_clock = 119000000,<br></blockquote><div><br></div><div><br></div><div>We have found that the 119MHz clock doesn't work in Chrome OS (the clock doesn't stabilize), so we removed it. We should probably remove it here as well.</div>

<div><br></div><div>Stéphane</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+               .conf = {<br>
+                       0x01, 0x91, 0x32, 0x14, 0x40, 0x60, 0xd8, 0x08,<br>
+                       0x06, 0x20, 0x2a, 0xd9, 0x45, 0xa0, 0xac, 0x80,<br>
+                       0x06, 0x80, 0x11, 0x04, 0x02, 0x22, 0x44, 0x86,<br>
+                       0x54, 0x9d, 0x25, 0x03, 0x00, 0x00, 0x01, 0x80,<br>
+               },<br>
+       },<br>
+       {<br>
                .pixel_clock = 146250000,<br>
                .conf = {<br>
                        0x01, 0xd1, 0x3d, 0x15, 0x40, 0x18, 0xfd, 0x08,<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.7.10.4<br>
<br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</font></span></blockquote></div><br></div></div>