<div dir="ltr">Hi Jingoo,<br><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Apr 18, 2014 at 2:27 PM, Jingoo Han <span dir="ltr"><<a href="mailto:jg1.han@samsung.com" target="_blank">jg1.han@samsung.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class=""><div class="h5">On Wednesday, April 16, 2014 11:33 PM, Ajay Kumar wrote:<br>
><br>
> Register exynos_dp_panel before the list of exynos crtcs and<br>
> connectors are probed.<br>
><br>
> This is needed because exynos_dp_panel should be registered to<br>
> the drm_panel list via panel-exynos-dp probe, i.e much before<br>
> exynos_dp_bind calls of_drm_find_panel().<br>
><br>
> Signed-off-by: Ajay Kumar <<a href="mailto:ajaykumar.rs@samsung.com">ajaykumar.rs@samsung.com</a>><br>
> ---<br>
>  drivers/gpu/drm/exynos/exynos_drm_drv.c | 11 +++++++++++<br>
>  drivers/gpu/drm/exynos/exynos_drm_drv.h |  1 +<br>
>  2 files changed, 12 insertions(+)<br>
><br>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c<br>
> index 1d1c604..47266e7 100644<br>
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c<br>
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c<br>
> @@ -560,12 +560,23 @@ static int exynos_drm_platform_probe(struct platform_device *pdev)<br>
>               goto err_unregister_ipp;<br>
>  #endif<br>
><br>
> +#ifdef CONFIG_DRM_PANEL_EXYNOS_DP<br>
> +     ret = platform_driver_register(&exynos_dp_panel_driver);<br>
> +     if (ret < 0)<br>
> +             goto err_unregister_dp_panel;<br>
> +#endif<br>
> +<br>
>       ret = component_master_add(&pdev->dev, &exynos_drm_ops);<br>
>       if (ret < 0)<br>
>               DRM_DEBUG_KMS("re-tried by last sub driver probed later.\n");<br>
><br>
>       return 0;<br>
><br>
> +#ifdef CONFIG_DRM_PANEL_EXYNOS_DP<br>
> +     platform_driver_unregister(&exynos_dp_panel_driver);<br>
> +err_unregister_dp_panel:<br>
> +#endif<br>
<br>
</div></div>Please add platform_driver_unregister() to exynos_drm_platform_remove(),<br></blockquote><div>Right, I have missed adding it in exynos_drm_platform_remove().<br><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">

as well as exynos_drm_platform_probe().<br>
<br></blockquote><div>I have already added for this case!<br> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Best regards,<br>
Jingoo Han<br>
<div class=""><div class="h5"><br>
> +<br>
>  #ifdef CONFIG_DRM_EXYNOS_IPP<br>
>       exynos_platform_device_ipp_unregister();<br>
>  err_unregister_ipp:<br>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h<br>
> index 257ce09..f606290 100644<br>
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h<br>
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h<br>
> @@ -368,4 +368,5 @@ extern struct platform_driver fimc_driver;<br>
>  extern struct platform_driver rotator_driver;<br>
>  extern struct platform_driver gsc_driver;<br>
>  extern struct platform_driver ipp_driver;<br>
> +extern struct platform_driver exynos_dp_panel_driver;<br>
>  #endif<br>
> --<br>
> 1.8.1.2<br>
<br>
</div></div></blockquote></div><br></div><div class="gmail_extra">Thanks and Regards,<br>Ajay Kumar<br></div></div></div>