<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2"" href="https://bugs.freedesktop.org/show_bug.cgi?id=77673#c9">Comment # 9</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - [bisected] moving moire starting with "drm/radeon: improve PLL params if we don't match exactly v2"" href="https://bugs.freedesktop.org/show_bug.cgi?id=77673">bug 77673</a> from <a class="email" href="mailto:deathsimple@vodafone.de" title="Christian König <deathsimple@vodafone.de>"> Christian König</a> <pre>(In reply to <a href="show_bug.cgi?id=77673#c8">comment #8</a>) > (In reply to <a href="show_bug.cgi?id=77673#c6">comment #6</a>) > > Please try the attached patch. > > > > We now always use the fixed reference divider if both RADEON_PLL_USE_REF_DIV > > and RADEON_PLL_USE_FRAC_FB_DIV are set. > > > > If only RADEON_PLL_USE_REF_DIV is set then we only use the fixed value as > > minimum limit. > > Does that make sense? Wouldn't we want to use use the fixed value if > RADEON_PLL_USE_REF_DIV regardless of whether RADEON_PLL_USE_FRAC_FB_DIV is > set? I don't really know, it's just the way how the old code handled this. If RADEON_PLL_USE_REF_DIV was set the RADEON_PLL_USE_FRAC_FB_DIV branch just used the value as provided, but the none RADEON_PLL_USE_FRAC_FB_DIV branch still tried to increment the vale.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>