<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [radeonsi] X11 can't start with acceleration enabled"
href="https://bugs.freedesktop.org/show_bug.cgi?id=60879#c89">Comment # 89</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [radeonsi] X11 can't start with acceleration enabled"
href="https://bugs.freedesktop.org/show_bug.cgi?id=60879">bug 60879</a>
from <span class="vcard"><a class="email" href="mailto:michel@daenzer.net" title="Michel Dänzer <michel@daenzer.net>"> <span class="fn">Michel Dänzer</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=60879#c88">comment #88</a>)
<span class="quote">> Is this patch supposed to apply cleanly against mesa 10.1.5?</span >
No, looks like it's for Git master, should probably apply against the 10.3
branch at least though.
(In reply to <a href="show_bug.cgi?id=60879#c87">comment #87</a>)
<span class="quote">> Fix v3</span >
[...]
<span class="quote">> + for (i = 0; i < num_se; i++) {
> + si_pm4_set_reg(pm4, GRBM_GFX_INDEX,
> + SE_INDEX(i) |
> + SH_BROADCAST_WRITES |
> + INSTANCE_BROADCAST_WRITES);
> + si_pm4_set_reg(pm4, R_028350_PA_SC_RASTER_CONFIG, raster_config);
> + }</span >
Since this uses the same raster_config value for all SEs, couldn't it just use
a single write with SE_BROADCAST_WRITES enabled in GRBM_GFX_INDEX?
If not:
<span class="quote">> + unsigned sh_per_se = MAX2(sctx->screen->b.info.max_sh_per_se, 1);
> + unsigned num_se = MAX2(sctx->screen->b.info.max_sh_per_se, 1);</span >
sh_per_se and num_se have the same value. Should one of them be calculated
differently, or does a single variable suffice?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>