<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Fan speed in idle at 40% with radeonsi and at 18% with catalyst"
href="https://bugs.freedesktop.org/show_bug.cgi?id=73338#c65">Comment # 65</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Fan speed in idle at 40% with radeonsi and at 18% with catalyst"
href="https://bugs.freedesktop.org/show_bug.cgi?id=73338">bug 73338</a>
from <span class="vcard"><a class="email" href="mailto:adonai@xaker.ru" title="Chernovsky Oleg <adonai@xaker.ru>"> <span class="fn">Chernovsky Oleg</span></a>
</span></b>
<pre><span class="quote">> 1. add the new dpm asic callbacks
> 2. add the common hwmon fan code. Make sure it's only enabled on asics
> which support manual fan control
> 3. wire up the CI specific code</span >
Ok, makes sense
<span class="quote">>
> As far as percent vs. rpm, I'm not sure which would be preferred. I think
> the hwmon subsystem generally prefers rpm. Maybe add callbacks for both
> percent and rpm and then check rdev->pm.fan_pulses_per_revolution. If it's
> 0, expose it as a percent. if not, expose as rpm. Thoughts? Might be
> worth asking on the hwmon mailing lists.</span >
Good idea, I'll try to test rpm behaviour today
<span class="quote">> Also, we should only expose these on asics which support fan control.</span >
No problem, some tinkering with `hwmon_attributes_visible` should make it.
I'll refresh & update patches on weekend.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>