<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Fan speed in idle at 40% with radeonsi and at 18% with catalyst" href="https://bugs.freedesktop.org/show_bug.cgi?id=73338#c64">Comment # 64</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Fan speed in idle at 40% with radeonsi and at 18% with catalyst" href="https://bugs.freedesktop.org/show_bug.cgi?id=73338">bug 73338</a> from <a class="email" href="mailto:alexdeucher@gmail.com" title="Alex Deucher <alexdeucher@gmail.com>"> Alex Deucher</a> <pre>(In reply to Chernovsky Oleg from <a href="show_bug.cgi?id=73338#c63">comment #63</a>) > Created <a href="attachment.cgi?id=110476" name="attach_110476" title="hwmon interface for manual fan control on CI cards">attachment 110476</a> <a href="attachment.cgi?id=110476&action=edit" title="hwmon interface for manual fan control on CI cards">[details]</a> <a href='page.cgi?id=splinter.html&bug=73338&attachment=110476'>[review]</a> [review] > hwmon interface for manual fan control on CI cards > > Hi Alex, I've made rough patch implementing hwmon interface for the code > you've provided. Please take a look (comments inside). > > Patch is done on top of your 3.19-wip branch. Looks good. Please split into 3 patches: 1. add the new dpm asic callbacks 2. add the common hwmon fan code. Make sure it's only enabled on asics which support manual fan control 3. wire up the CI specific code As far as percent vs. rpm, I'm not sure which would be preferred. I think the hwmon subsystem generally prefers rpm. Maybe add callbacks for both percent and rpm and then check rdev->pm.fan_pulses_per_revolution. If it's 0, expose it as a percent. if not, expose as rpm. Thoughts? Might be worth asking on the hwmon mailing lists. Also, we should only expose these on asics which support fan control.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>