<html><head><meta http-equiv="content-type" content="text/html; charset=UTF-8"><style>body { line-height: 1.5; }blockquote { margin-top: 0px; margin-bottom: 0px; margin-left: 0.5em; }body { font-size: 10.5pt; font-family: 宋体; color: rgb(0, 0, 0); line-height: 1.5; }body { font-size: 10.5pt; font-family: 宋体; color: rgb(0, 0, 0); line-height: 1.5; }</style></head><body> <div><span></span>Hi lars:</div><div><br></div> <div>thks for your review, I will move it to hdmi audio driver, give the codec_name & codec_dai_name an const string.</div><div><br></div>Best Regards.<br><hr style="width: 210px; height: 1px;" color="#b5c4df" size="1" align="left"> <div><span><div style="MARGIN: 10px; FONT-FAMILY: verdana; FONT-SIZE: 10pt"><font color="#c0c0c0" face="Verdana" style="line-height: normal;"><font size="2" face="Verdana"><font color="#c0c0c0" size="2" face="Verdana"><div><font color="#000080">Yang KuanKuan | Software Engineer | 15060416783 | ykk@rock-chips.com</font></div></font></font></font></div></span></div> <blockquote style="margin-top: 0px; margin-bottom: 0px; margin-left: 0.5em;"><div> </div><div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm"><div style="PADDING-RIGHT: 8px; PADDING-LEFT: 8px; FONT-SIZE: 12px;FONT-FAMILY:tahoma;COLOR:#000000; BACKGROUND: #efefef; PADDING-BOTTOM: 8px; PADDING-TOP: 8px"><div><b>From:</b> <a href="mailto:lars@metafoo.de">Lars-Peter Clausen</a></div><div><b>Date:</b> 2014-12-15 17:02</div><div><b>To:</b> <a href="mailto:ykk@rock-chips.com">Yakir Yang</a></div><div><b>CC:</b> <a href="mailto:heiko@sntech.de">Heiko Stuebner</a>; <a href="mailto:robh+dt@kernel.org">Rob Herring</a>; <a href="mailto:pawel.moll@arm.com">Pawel Moll</a>; <a href="mailto:mark.rutland@arm.com">Mark Rutland</a>; <a href="mailto:ijc+devicetree@hellion.org.uk">Ian Campbell</a>; <a href="mailto:galak@codeaurora.org">Kumar Gala</a>; <a href="mailto:linux@arm.linux.org.uk">Russell King</a>; <a href="mailto:p.zabel@pengutronix.de">Philipp Zabel</a>; <a href="mailto:Zubair.Kakakhel@imgtec.com">Zubair.Kakakhel</a>; <a href="mailto:fabio.estevam@freescale.com">Fabio Estevam</a>; <a href="mailto:shawn.guo@linaro.org">Shawn Guo</a>; <a href="mailto:dri-devel@lists.freedesktop.org">dri-devel</a>; <a href="mailto:djkurtz@chromium.org">Daniel Kurtz</a>; <a href="mailto:sonnyrao@chromium.org">Sonny Rao</a>; <a href="mailto:dgreid@chromium.org">Dylan Reid</a>; <a href="mailto:jay.xu@rock-chips.com">Xu Jianqun</a>; <a href="mailto:marcheu@chromium.org">St��phane Marchesin</a>; <a href="mailto:brian.austin@cirrus.com">Brian Austin</a>; <a href="mailto:bardliao@realtek.com">Bard Liao</a>; <a href="mailto:jcmvbkbc@gmail.com">Max Filippov</a>; <a href="mailto:oder_chiou@realtek.com">Oder Chiou</a>; <a href="mailto:devicetree@vger.kernel.org">devicetree</a>; <a href="mailto:linux-kernel@vger.kernel.org">linux-kernel</a>; <a href="mailto:linux-arm-kernel@lists.infradead.org">linux-arm-kernel</a>; <a href="mailto:linux-rockchip@lists.infradead.org">linux-rockchip</a>; <a href="mailto:alsa-devel@alsa-project.org">alsa-devel</a>; <a href="mailto:arnd@arndb.de">Arnd Bergmann</a>; <a href="mailto:airlied@linux.ie">David Airlie</a>; <a href="mailto:xobs@kosagi.com">Sean Cross</a>; <a href="mailto:grant.likely@linaro.org">Grant Likely</a>; <a href="mailto:gregkh@linuxfoundation.org">Greg Kroah-Hartman</a>; <a href="mailto:benzh@chromium.org">Ben Zhang</a>; <a href="mailto:lgirdwood@gmail.com">Liam Girdwood</a>; <a href="mailto:perex@perex.cz">Jaroslav Kysela</a>; <a href="mailto:broonie@kernel.org">Mark Brown</a>; <a href="mailto:tiwai@suse.de">Takashi Iwai</a>; <a href="mailto:jsarha@ti.com">Jyri Sarha</a></div><div><b>Subject:</b> Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio</div></div></div><div><div>On 12/15/2014 03:55 AM, Yakir Yang wrote:</div> <div>[...]</div> <div>> +- codec-name: the dw-hdmi codec's device name</div> <div>> +- codec-dai-name: the dw-hdmi codec's dai name</div> <div> </div> <div>Please you phandles for this, the names are Linux driver and framework </div> <div>specific details. That should not leak into the DT bindings.</div> <div> </div> <div>[..]</div> <div> </div> <div> </div> </div></blockquote> </body></html>