<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2014-12-10 22:07 GMT+08:00 Thierry Reding <span dir="ltr"><<a href="mailto:thierry.reding@gmail.com" target="_blank">thierry.reding@gmail.com</a>></span>:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, Dec 10, 2014 at 04:37:25PM +0800, Liu Ying wrote:<br>
[...]<br>
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi<br>
[...]<br>
<span class="">> +&mipi_dsi {<br>
> +     status = "okay";<br>
> +<br>
> +     panel@0 {<br>
> +             compatible = "himax,hx8369a-dsi";<br>
> +             reg = <0>;<br>
> +             pinctrl-names = "default";<br>
> +             pinctrl-0 = <&pinctrl_mipi_panel>;<br>
> +             reset-gpios = <&gpio6 11 GPIO_ACTIVE_LOW>;<br>
> +             reset-delay = <120>;<br>
> +             bs2-gpios = <&gpio6 14 GPIO_ACTIVE_HIGH>;<br>
> +             data-lanes = <2>;<br>
> +             panel-width-mm = <45>;<br>
> +             panel-height-mm = <76>;<br>
> +             bs = <10>;<br>
> +             status = "okay";<br>
> +<br>
> +             display-timings {<br>
> +                     native-mode = <&timing1>;<br>
> +                     timing1: truly-tft480800-16-e {<br>
<br>
</span>This is the only place where Truly is mentioned. The panel vendor is<br>
either Truly or it is Himax, it can't be a mix. From this example and<br>
your patch description it seems like Truly is the manufacturer of the<br>
panel, hence the panel compatible should really be:<br>
<br>
        compatible = "truly,tft480800-16-e";<br></blockquote><div><br></div><div>May I change the compatible string to be '"truly,tft480800-16-e-dsi"?</div><div>This way, the dsi driver may match the dsi device.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
That it uses an HX8369A chip internally is really secondary, at least<br>
regarding the binding. If we ever get need to support multiple panels<br>
with the same driver IC the proper solution would be to abstract that<br>
code out into a helper library that is used from the various panel<br>
drivers.<br>
<span class="HOEnZb"><font color="#888888"><br>
Thierry<br>
</font></span><br>_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br></blockquote></div>
</div></div>