<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi,<br>
<br>
i found a bug in uninorth-agp.c, function uninorth_fetch_size.<br>
<br>
the line <br>
<br>
<pre><a href="http://lxr.free-electrons.com/ident?i=size">size</a> = <a href="http://lxr.free-electrons.com/ident?i=memparse">memparse</a>(<a href="http://lxr.free-electrons.com/ident?i=aperture">aperture</a>, &<a href="http://lxr.free-electrons.com/ident?i=aperture">aperture</a>) >> 20;
always sets size to zero which makes the driver allocate the default size of 256 MB which is obviously too large for older uninorth revisions.
I split the line into memparse and shifting and inserted diagnostic messages, output with uninorth_agp.aperture = 32 as boot parameter:
Feb 15 19:12:44 mac-mini kernel: [ 2.568636] agpgart-uninorth 0000:00:0b.0: size in uninorth_fetch_size after memparse: 32
Feb 15 19:12:44 mac-mini kernel: [ 2.568642] agpgart-uninorth 0000:00:0b.0: size after >> 20: 0
</pre>
It would be nice if a patch could be produced so i can experiment
with different aperture sizes without having to rebuild the kernel
every time :-)<br>
<br>
Cheers<br>
<br>
Jochen<br>
</body>
</html>