<div dir="ltr">Hi Daniel,<br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 17, 2015 at 4:40 PM, Daniel Vetter <span dir="ltr"><<a href="mailto:daniel@ffwll.ch" target="_blank">daniel@ffwll.ch</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">On Tue, Mar 17, 2015 at 03:30:27PM +0800, John Hunter wrote:<br>
> use outdise defined variable can reduce the recaculate of the<br>
> count of planes, crtcs and connectors.<br>
><br>
> Signed-off-by: John Hunter <<a href="mailto:zhjwpku@gmail.com">zhjwpku@gmail.com</a>><br>
<br>
</span>Hm, what's the benefit you see for this change? The lines aren't too long<br>
yet and we don't reuse the expression, so imo code readability isn't<br>
improved.<br></blockquote><div>I change this just reference some other functions in the same file.</div><div>like,</div><div>     drm_atomic_helper_check_planes</div><div>     wait_for_fences</div><div>     ...</div><div>I really think we should keep the same coding style in the same file.</div><div>If I am wrong with that, just ignore this patch :-)</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
-Daniel<br>
<div><div class="h5">> ---<br>
>  drivers/gpu/drm/drm_atomic_helper.c | 9 ++++++---<br>
>  1 file changed, 6 insertions(+), 3 deletions(-)<br>
><br>
> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c<br>
> index 39369ee..20376e6 100644<br>
> --- a/drivers/gpu/drm/drm_atomic_helper.c<br>
> +++ b/drivers/gpu/drm/drm_atomic_helper.c<br>
> @@ -1301,8 +1301,11 @@ void drm_atomic_helper_swap_state(struct drm_device *dev,<br>
>                                 struct drm_atomic_state *state)<br>
>  {<br>
>       int i;<br>
> +     int nconnectors = dev->mode_config.num_connector;<br>
> +     int ncrtcs = dev->mode_config.num_crtc;<br>
> +     int nplanes = dev->mode_config.num_total_plane;<br>
><br>
> -     for (i = 0; i < dev->mode_config.num_connector; i++) {<br>
> +     for (i = 0; i < nconnectors; i++) {<br>
>               struct drm_connector *connector = state->connectors[i];<br>
><br>
>               if (!connector)<br>
> @@ -1313,7 +1316,7 @@ void drm_atomic_helper_swap_state(struct drm_device *dev,<br>
>               connector->state->state = NULL;<br>
>       }<br>
><br>
> -     for (i = 0; i < dev->mode_config.num_crtc; i++) {<br>
> +     for (i = 0; i < ncrtcs; i++) {<br>
>               struct drm_crtc *crtc = state->crtcs[i];<br>
><br>
>               if (!crtc)<br>
> @@ -1324,7 +1327,7 @@ void drm_atomic_helper_swap_state(struct drm_device *dev,<br>
>               crtc->state->state = NULL;<br>
>       }<br>
><br>
> -     for (i = 0; i < dev->mode_config.num_total_plane; i++) {<br>
> +     for (i = 0; i < nplanes; i++) {<br>
>               struct drm_plane *plane = state->planes[i];<br>
><br>
>               if (!plane)<br>
> --<br>
> 1.9.1<br>
><br>
><br>
</div></div>> _______________________________________________<br>
> dri-devel mailing list<br>
> <a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
<span class=""><font color="#888888"><br>
--<br>
Daniel Vetter<br>
Software Engineer, Intel Corporation<br>
<a href="http://blog.ffwll.ch" target="_blank">http://blog.ffwll.ch</a><br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div>Best regards<br></div><div>Junwang Zhao</div><div>Microprocessor Research and Develop Center</div><div>Department of Computer Science &Technology</div><div>Peking University</div><div>Beijing, 100871, PRC</div></div></div>
</div></div>