<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - GPU Fault 147 and Ring Stalls and Tests Fail in Pillars of Eternity" href="https://bugs.freedesktop.org/show_bug.cgi?id=89785#c12">Comment # 12</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - GPU Fault 147 and Ring Stalls and Tests Fail in Pillars of Eternity" href="https://bugs.freedesktop.org/show_bug.cgi?id=89785">bug 89785</a> from <a class="email" href="mailto:michel@daenzer.net" title="Michel Dänzer <michel@daenzer.net>"> Michel Dänzer</a> <pre>Comment on <a href="attachment.cgi?id=114780" name="attach_114780" title="Fix for bug described in commet 4">attachment 114780</a> <a href="attachment.cgi?id=114780&action=edit" title="Fix for bug described in commet 4">[details]</a> <a href='page.cgi?id=splinter.html&bug=89785&attachment=114780'>[review]</a> Fix for bug described in commet 4 Review of <a href="attachment.cgi?id=114780" name="attach_114780" title="Fix for bug described in commet 4">attachment 114780</a> <a href="attachment.cgi?id=114780&action=edit" title="Fix for bug described in commet 4">[details]</a> <a href='page.cgi?id=splinter.html&bug=89785&attachment=114780'>[review]</a>: ----------------------------------------------------------------- I think it would be better if SI_KILL could be fixed not to clobber VCC in the first place, e.g. by using the 64-bit encoding of the v_cmp(x)_lt_f32[0] instruction. But failing that, this looks good. [0] BTW, it's currently using v_cmpx_le_f32, but I think that's incorrect, as the comment says "Clear this thread from the exec mask if the operand is negative".</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>