<div dir="ltr">Sure, but I need Daniel to admit that, because maybe include the two header <div>file make it easier to understand.<div>And after checked other files in drm/i915, I found that a lot other file do the</div><div>same thing(include both header file). So I will just wait Daniel to wait up and</div></div><div>give me the order :-)</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 22, 2015 at 10:35 AM, <a href="mailto:yongjun_wei@trendmicro.com.cn">yongjun_wei@trendmicro.com.cn</a> <span dir="ltr"><<a href="mailto:yongjun_wei@trendmicro.com.cn" target="_blank">yongjun_wei@trendmicro.com.cn</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div lang="ZH-CN" link="blue" vlink="purple"> <div> <p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1f497d">Hi </span><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">John,<u></u><u></u></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""><u></u> <u></u></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1f497d">Feel free to submit a new patch.<u></u><u></u></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1f497d">Regards,<u></u><u></u></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1f497d">Yongjun Wei<u></u><u></u></span></p> <p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p> <p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> John Hunter [mailto:<a href="mailto:zhjwpku@gmail.com" target="_blank">zhjwpku@gmail.com</a>] <br> <b>Sent:</b> 2015</span><span style="font-size:10.0pt">年</span><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">4</span><span style="font-size:10.0pt">月</span><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">22</span><span style="font-size:10.0pt">日</span><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> 10:30<br> <b>To:</b> <a href="mailto:weiyj_lk@163.com" target="_blank">weiyj_lk@163.com</a>; Daniel Vetter; Jani Nikula; David Airlie; Yongjun Wei (RD-CN); <a href="mailto:intel-gfx@lists.freedesktop.org" target="_blank">intel-gfx@lists.freedesktop.org</a>; <a href="mailto:dri-devel@lists.freedesktop.org" target="_blank">dri-devel@lists.freedesktop.org</a>; open list<span class=""><br> <b>Subject:</b> Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c<u></u><u></u></span></span></p> <p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p> <div> <p class="MsoNormal"><span lang="EN-US">Hi, <u></u><u></u></span></p><div><div class="h5"> <div> <p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US">I think maybe we should remove both of the two lines: <u></u><u></u></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US">#include "intel_drv.h"<u></u><u></u></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US">#include "i915_drv.h"<u></u><u></u></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US">Because we have<b> two</b> "intel_drv.h" and <b>one</b> "i915_drv.h", and <u></u><u></u></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US">"i915_drv.h" has already been included in the "intel_drv.h".<u></u><u></u></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US">I not sure whether i am right. If you need me to do the patch,<u></u><u></u></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US">let me know.<u></u><u></u></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p> </div> </div></div></div><div><div class="h5"> <div> <p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p> <div> <p class="MsoNormal"><span lang="EN-US">On Thu, Apr 16, 2015 at 10:30 PM, Daniel Vetter <<a href="mailto:daniel@ffwll.ch" target="_blank">daniel@ffwll.ch</a>> wrote:<u></u><u></u></span></p> <p class="MsoNormal"><span lang="EN-US">On Thu, Apr 16, 2015 at 09:11:08PM +0800, <a href="mailto:weiyj_lk@163.com" target="_blank">weiyj_lk@163.com</a> wrote:<br> > From: Wei Yongjun <<a href="mailto:yongjun_wei@trendmicro.com.cn" target="_blank">yongjun_wei@trendmicro.com.cn</a>><br> ><br> > Remove duplicated include.<br> ><br> > Signed-off-by: Wei Yongjun <<a href="mailto:yongjun_wei@trendmicro.com.cn" target="_blank">yongjun_wei@trendmicro.com.cn</a>><br> <br> Queued for -next, thanks for the patch.<br> -Daniel<br> <br> > ---<br> > drivers/gpu/drm/i915/intel_audio.c | 1 -<br> > 1 file changed, 1 deletion(-)<br> ><br> > diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c<br> > index 2396cc7..d00d488 100644<br> > --- a/drivers/gpu/drm/i915/intel_audio.c<br> > +++ b/drivers/gpu/drm/i915/intel_audio.c<br> > @@ -28,7 +28,6 @@<br> ><br> > #include <drm/drmP.h><br> > #include <drm/drm_edid.h><br> > -#include "intel_drv.h"<br> > #include "i915_drv.h"<br> ><br> > /**<br> ><br> > _______________________________________________<br> > Intel-gfx mailing list<br> > <a href="mailto:Intel-gfx@lists.freedesktop.org" target="_blank">Intel-gfx@lists.freedesktop.org</a><br> > <a href="http://lists.freedesktop.org/mailman/listinfo/intel-gfx" target="_blank"> http://lists.freedesktop.org/mailman/listinfo/intel-gfx</a><br> <span style="color:#888888"><br> <span>--</span><br> <span>Daniel Vetter</span><br> <span>Software Engineer, Intel Corporation</span><br> <span><a href="http://blog.ffwll.ch" target="_blank">http://blog.ffwll.ch</a></span></span><u></u><u></u></span></p> <div> <div> <p class="MsoNormal"><span lang="EN-US">_______________________________________________<br> dri-devel mailing list<br> <a href="mailto:dri-devel@lists.freedesktop.org" target="_blank">dri-devel@lists.freedesktop.org</a><br> <a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><u></u><u></u></span></p> </div> </div> </div> <p class="MsoNormal"><span lang="EN-US"><br> <br clear="all"> <u></u><u></u></span></p> <div> <p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p> </div> <p class="MsoNormal"><span lang="EN-US">-- <u></u><u></u></span></p> <div> <div> <div> <p class="MsoNormal"><span lang="EN-US">Best regards<u></u><u></u></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US">Junwang Zhao<u></u><u></u></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US">Microprocessor Research and Develop Center<u></u><u></u></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US">Department of Computer Science &Technology<u></u><u></u></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US">Peking University<u></u><u></u></span></p> </div> <div> <p class="MsoNormal"><span lang="EN-US">Beijing, 100871, PRC<u></u><u></u></span></p> </div> </div> </div> </div> </div></div><table border="0" cellpadding="0"> <tbody> <tr> <td style="background:white;padding:.75pt .75pt .75pt .75pt"> <pre><span lang="EN-US" style="color:black">======================================================= <u></u><u></u></span></pre> <pre><span lang="EN-US" style="color:black">This message has been analyzed by Deep Discovery Email Inspector.<u></u><u></u></span></pre> </td> </tr> </tbody> </table> <p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p> </div> </div> <table><tbody><tr><td bgcolor="#ffffff"><font color="#000000"><pre><table><tbody><tr><td><pre>TREND MICRO EMAIL NOTICE The information contained in this email and any attachments is confidential and may be subject to copyright or other intellectual property protection. If you are not the intended recipient, you are not authorized to use or disclose this information, and we request that you notify us by reply mail or telephone and delete the original message from your mail system. </pre></td></tr></tbody></table></pre></font></td></tr></tbody></table></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div>Best regards<br></div><div>Junwang Zhao</div><div>Microprocessor Research and Develop Center</div><div>Department of Computer Science &Technology</div><div>Peking University</div><div>Beijing, 100871, PRC</div></div></div> </div>