<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass"
href="https://bugs.freedesktop.org/show_bug.cgi?id=90056#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass"
href="https://bugs.freedesktop.org/show_bug.cgi?id=90056">bug 90056</a>
from <span class="vcard"><a class="email" href="mailto:adf.lists@gmail.com" title="Andy Furniss <adf.lists@gmail.com>"> <span class="fn">Andy Furniss</span></a>
</span></b>
<pre>(In reply to Tom Stellard from <a href="show_bug.cgi?id=90056#c12">comment #12</a>)
<span class="quote">> (In reply to Andy Furniss from <a href="show_bug.cgi?id=90056#c10">comment #10</a>)
> > (In reply to Grigori Goronzy from <a href="show_bug.cgi?id=90056#c9">comment #9</a>)
> > > Created <span class=""><a href="attachment.cgi?id=115409" name="attach_115409" title="Full shader">attachment 115409</a> <a href="attachment.cgi?id=115409&action=edit" title="Full shader">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=90056&attachment=115409'>[review]</a> [review] [review] [review]
> > > Full shader
> > >
> > > That does not help either. Seems to break the SSA somehow. Full shader that
> > > triggers the bug attached.
> > >
> > > The patch I posted earlier help with the the reduced testcase, but not with
> > > the full shader. Both undef incoming values in phi nodes and undef branch
> > > conditions cause problems in different ways.
> >
> > With the second patch + valley I get -
> >
> > valley_x64: LiveVariables.cpp:114: void
> > llvm::LiveVariables::MarkVirtRegAliveInBlock(llvm::LiveVariables::VarInfo &,
> > llvm::MachineBasicBlock *, llvm::MachineBasicBlock *,
> > std::vector<MachineBasicBlock *> &): Assertion `MBB != &MF->front() &&
> > "Can't find reaching def for virtreg"' failed.
>
> Did test with only the patch from <a href="show_bug.cgi?id=90056#c8">comment #8</a> or did you test with both
> patches?</span >
Just #8 but I just tried with both and get the same fail.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>