<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Lack of grass in The Talos Principle on radeonsi (native\wine\nine)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89069#c34">Comment # 34</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Lack of grass in The Talos Principle on radeonsi (native\wine\nine)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89069">bug 89069</a>
from <span class="vcard"><a class="email" href="mailto:daniel@constexpr.org" title="Daniel Scharrer <daniel@constexpr.org>"> <span class="fn">Daniel Scharrer</span></a>
</span></b>
<pre>(In reply to smoki from <a href="show_bug.cgi?id=89069#c28">comment #28</a>)
<span class="quote">> After
> <a href="http://cgit.freedesktop.org/mesa/mesa/commit/">http://cgit.freedesktop.org/mesa/mesa/commit/</a>
> ?id=c6d79ed289a75f13c65f011be870f7e43a0fedc7 which improve code quality i
> can enable unsafe-fp-math and grass is now there with trace from <a href="show_bug.cgi?id=89069#c7">Comment 7</a>
>
> Daniel and others, you might want to recheck this.</span >
I can confirm that there is still grass with Mesa git-e1ae0c3 + LLVM r236436
and
diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c.old
b/src/gallium/drivers/radeon/radeon_llvm_emit.c
index 624077c..0f9dbab 100644
--- a/src/gallium/drivers/radeon/radeon_llvm_emit.c.old
+++ b/src/gallium/drivers/radeon/radeon_llvm_emit.c
@@ -80,6 +80,10 @@ void radeon_llvm_shader_type(LLVMValueRef F, unsigned type)
sprintf(Str, "%1d", llvm_type);
LLVMAddTargetDependentFunctionAttr(F, "ShaderType", Str);
+
+ if (type != TGSI_PROCESSOR_COMPUTE) {
+ LLVMAddTargetDependentFunctionAttr(F, "unsafe-fp-math",
"true");
+ }
}
I still get GPU faults with The Talos Principle, even with "unsafe-fp-math"
enabled now - although not with either of the traces I posted. I also get some
garbage rendered / flickering stuff, but I don't think it's related to
"unsafe-fp-math". I'll test more and post a new trace when I have time.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>