<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 6, 2015 at 4:00 AM, SF Markus Elfring <span dir="ltr"><<a href="mailto:elfring@users.sourceforge.net" target="_blank">elfring@users.sourceforge.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Markus Elfring <<a href="mailto:elfring@users.sourceforge.net">elfring@users.sourceforge.net</a>><br>
Date: Sun, 5 Jul 2015 21:55:10 +0200<br>
<br>
The drm_property_unreference_blob() function tests whether its argument<br>
is NULL and then returns immediately.<br>
Thus the test around the call is not needed.<br>
<br>
This issue was detected by using the Coccinelle software.<br>
<br>
Signed-off-by: Markus Elfring <<a href="mailto:elfring@users.sourceforge.net">elfring@users.sourceforge.net</a>><br>
</blockquote><div><br></div><div>Reviewed-by: Zhao Junwang <<a href="mailto:zhjwpku@gmail.com">zhjwpku@gmail.com</a>> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---<br>
 drivers/gpu/drm/drm_crtc.c | 4 +---<br>
 1 file changed, 1 insertion(+), 3 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c<br>
index 2d57fc5..6e4c8b0 100644<br>
--- a/drivers/gpu/drm/drm_crtc.c<br>
+++ b/drivers/gpu/drm/drm_crtc.c<br>
@@ -4469,9 +4469,7 @@ static int drm_property_replace_global_blob(struct drm_device *dev,<br>
                        goto err_created;<br>
        }<br>
<br>
-       if (old_blob)<br>
-               drm_property_unreference_blob(old_blob);<br>
-<br>
+       drm_property_unreference_blob(old_blob);<br>
        *replace = new_blob;<br>
<br>
        return 0;<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.4.5<br>
<br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div>Best regards<br></div><div>Junwang Zhao</div><div>Microprocessor Research and Develop Center</div><div>Department of Computer Science &Technology</div><div>Peking University</div><div>Beijing, 100871, PRC</div></div></div>
</div></div>