<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 8, 2015 at 8:50 PM, Benjamin Gaignard <span dir="ltr"><<a href="mailto:benjamin.gaignard@linaro.org" target="_blank">benjamin.gaignard@linaro.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Useful to avoid recompiling to enable/disable fbdev.<br>
<br>
Signed-off-by: Benjamin Gaignard <<a href="mailto:benjamin.gaignard@linaro.org">benjamin.gaignard@linaro.org</a>><br>
</blockquote><div><br></div><div>Reviewed-by: Zhao Junwang <<a href="mailto:zhjwpku@gmail.com">zhjwpku@gmail.com</a>></div><div><br></div><div>Bochs has the moduleparam for fbdev, lgtm.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---<br>
drivers/gpu/drm/sti/Kconfig | 6 ------<br>
drivers/gpu/drm/sti/sti_drm_drv.c | 13 ++++++++-----<br>
2 files changed, 8 insertions(+), 11 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kconfig<br>
index fbccc10..e3aa5af 100644<br>
--- a/drivers/gpu/drm/sti/Kconfig<br>
+++ b/drivers/gpu/drm/sti/Kconfig<br>
@@ -9,9 +9,3 @@ config DRM_STI<br>
select FW_LOADER_USER_HELPER_FALLBACK<br>
help<br>
Choose this option to enable DRM on STM stiH41x chipset<br>
-<br>
-config DRM_STI_FBDEV<br>
- bool "DRM frame buffer device for STMicroelectronics SoC stiH41x Serie"<br>
- depends on DRM_STI<br>
- help<br>
- Choose this option to enable FBDEV on top of DRM for STM stiH41x chipset<br>
diff --git a/drivers/gpu/drm/sti/sti_drm_drv.c b/drivers/gpu/drm/sti/sti_drm_drv.c<br>
index 59d558b..d0fb54a 100644<br>
--- a/drivers/gpu/drm/sti/sti_drm_drv.c<br>
+++ b/drivers/gpu/drm/sti/sti_drm_drv.c<br>
@@ -30,6 +30,10 @@<br>
#define STI_MAX_FB_HEIGHT 4096<br>
#define STI_MAX_FB_WIDTH 4096<br>
<br>
+static bool fbdev;<br>
+MODULE_PARM_DESC(fbdev, "Enable fbdev compat layer");<br>
+module_param(fbdev, bool, S_IRUGO | S_IWUSR);<br>
+<br>
static void sti_drm_atomic_schedule(struct sti_drm_private *private,<br>
struct drm_atomic_state *state)<br>
{<br>
@@ -160,11 +164,10 @@ static int sti_drm_load(struct drm_device *dev, unsigned long flags)<br>
<br>
drm_mode_config_reset(dev);<br>
<br>
-#ifdef CONFIG_DRM_STI_FBDEV<br>
- drm_fbdev_cma_init(dev, 32,<br>
- dev->mode_config.num_crtc,<br>
- dev->mode_config.num_connector);<br>
-#endif<br>
+ if (fbdev)<br>
+ drm_fbdev_cma_init(dev, 32, dev->mode_config.num_crtc,<br>
+ dev->mode_config.num_connector);<br>
+<br>
return 0;<br>
}<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
1.9.1<br>
<br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div>Best regards<br></div><div>Junwang Zhao</div><div>Microprocessor Research and Develop Center</div><div>Department of Computer Science &Technology</div><div>Peking University</div><div>Beijing, 100871, PRC</div></div></div>
</div></div>