<html> <head> <meta content="text/html; charset=utf-8" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> Ajay, <div class="moz-cite-prefix">在 2015/8/7 14:11, Ajay kumar 写道: </div> <blockquote cite="mid:CAEC9eQNBU4oQnAFtWRNJonHOB-1XNhCO0r7fUiHohBErJE_sFQ@mail.gmail.com" type="cite">+Sean </blockquote> Woh, okay, I will loop you and Sean to cc list in follow versions ;) -Yakir <blockquote cite="mid:CAEC9eQNBU4oQnAFtWRNJonHOB-1XNhCO0r7fUiHohBErJE_sFQ@mail.gmail.com" type="cite">On Thursday, August 6, 2015, Yakir Yang <<a moz-do-not-send="true" href="mailto:ykk@rock-chips.com"><a class="moz-txt-link-abbreviated" href="mailto:ykk@rock-chips.com">ykk@rock-chips.com</a></a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Jingoo, 在 2015/8/6 22:41, Jingoo Han 写道: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> On Thursday, August 06, 2015 10:49 PM, Yakir Yang wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Hi all, Samsung exynos and Rockchip rk3288 almost share same dp controller, so I split the common code out, then rk3288 and exynos can re-used the same dp core driver. Cause I can't find the exact IP name of exynos dp controller, so I decide to name dp core driver with "analogix" which I find in rk3288 eDP TRM ;) </blockquote> OK, I see. The Samsung Exynos eDP contoller and Rockchip rk3288 eDP contoller share the same IP. So, a lot of parts can be re-used. I agree with this. However, we have to review the code carefully, as others did. </blockquote> Yeah, feel happy to be reviewed ;) <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> I also cannot find the exact IP name. The "analogix" may be the vendor name of this IP. </blockquote> Okay, so "analogix" is okay for now Thanks, - Yakir <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Best regards, Jingoo Han <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Beyond that, there are three light registers setting differents bewteen exynos and rk3288. 1. RK3288 have five special pll resigters which not indicata in exynos dp controller. 2. The address of DP_PHY_PD(dp phy power manager register) are different between rk3288 and exynos. 3. Rk3288 and exynos have different setting with AUX_HW_RETRY_CTL(dp debug register). My series patches can be divider into two parts: One for spliting the analogix_dp code from exynos dp driver. Another are trying to add rk3288 dp driver support. Best regards, - Yakir -- 2.1.2 </blockquote> </blockquote> -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to <a moz-do-not-send="true">majordomo@vger.kernel.org</a> More majordomo info at <a moz-do-not-send="true" href="http://vger.kernel.org/majordomo-info.html" target="_blank">http://vger.kernel.org/majordomo-info.html</a> </blockquote> </blockquote> </body> </html>