<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>On 2015. 8. 21., at PM 7:01, Yakir Yang <<a href="mailto:ykk@rock-chips.com">ykk@rock-chips.com</a>> wrote:</div><div><br></div><blockquote type="cite"><div>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
Hi Jingoo,<br>
<br>
<div class="moz-cite-prefix">在 2015/8/21 16:20, Jingoo Han 写道:<br>
</div>
<blockquote cite="mid:105A0032-83A0-4B75-AE94-258F12451670@gmail.com" type="cite">
<pre wrap="">On 2015. 8. 19., at PM 11:48, Yakir Yang <a class="moz-txt-link-rfc2396E" href="mailto:ykk@rock-chips.com"><ykk@rock-chips.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
</pre>
</blockquote>
<pre wrap="">.....
</pre>
<blockquote type="cite">
<pre wrap="">.../bindings/video/analogix_dp-rockchip.txt | 83 ++
.../devicetree/bindings/video/exynos_dp.txt | 51 +-
arch/arm/boot/dts/exynos5250-arndale.dts | 10 +-
arch/arm/boot/dts/exynos5250-smdk5250.dts | 10 +-
arch/arm/boot/dts/exynos5250-snow.dts | 12 +-
arch/arm/boot/dts/exynos5250-spring.dts | 12 +-
arch/arm/boot/dts/exynos5420-peach-pit.dts | 12 +-
arch/arm/boot/dts/exynos5420-smdk5420.dts | 10 +-
arch/arm/boot/dts/exynos5800-peach-pi.dts | 12 +-
drivers/gpu/drm/bridge/Kconfig | 5 +
drivers/gpu/drm/bridge/Makefile | 1 +
drivers/gpu/drm/bridge/analogix_dp_core.c | 1382 +++++++++++++++++++
drivers/gpu/drm/bridge/analogix_dp_core.h | 286 ++++
drivers/gpu/drm/bridge/analogix_dp_reg.c | 1294 ++++++++++++++++++
.../exynos_dp_reg.h => bridge/analogix_dp_reg.h} | 270 ++--
drivers/gpu/drm/exynos/Kconfig | 5 +-
drivers/gpu/drm/exynos/Makefile | 2 +-
drivers/gpu/drm/exynos/analogix_dp-exynos.c | 347 +++++
</pre>
</blockquote>
<pre wrap="">Would you change this file name to "exynos_dp.c"?
</pre>
</blockquote>
<br>
Sorry, I don't think so ;(<br>
<br>
I think IP_name+Soc_name would be better in this re-use case.</div></blockquote><div><br></div><div>So? Is there the naming rule such as "IP_name+SoC_name"?</div><br><blockquote type="cite"><div> Beside
I see<br>
there are lots of driver named with this format in kernel, such as
dw_hdmi & dw_mmc<br></div></blockquote><div><br></div><div>Please look at other dw cases.</div><div>For example, look at dw_pcie.</div><div><br></div><div>drivers/pci/host/</div><div>pcie-designware.c</div><div>pci-spear13xx.c</div><div>pci-exynos.c</div><div><br></div><div>In this case, pci-spear13xx.c and pci-exynos.c do not use "IP_name+SoC_name", even though these are dw IPs.</div><div><br></div><div>Also, naming consistency is more important.</div><div>Now, Exynos DRM files are using "exynos_drm_" prefix.</div><div><br></div><div>drivers/gpu/drm/exynos/</div><div>exynos_drm_buf.c</div><div>exynos_drm_core.c</div><div>....</div><div><br></div><div>However, "analogix_dp-exynos.c" looks very inconsistent.</div><div><br></div><div>If there is no strict naming rule, please use "exynos_dp.c"</div><div>or "exynos_drm_dp.c". </div><div><br></div><div>Best regards,</div><div>Jingoo Han</div><div><br></div><blockquote type="cite"><div>
<br>
(cr) (chromeos-3.14) yakir@server
~/trunk/src/third_party/kernel/v3.14 $<font color="#000099"> ls
drivers/gpu/drm/imx/</font><br>
<font color="#990000">dw_hdmi-imx.c</font> imx-drm.h
imx-tve.c ipuv3-plane.c Kconfig parallel-display.c<br>
<br>
(cr) (chromeos-3.14) yakir@server
~/trunk/src/third_party/kernel/v3.14 $<font color="#000099"> ls
drivers/mmc/host/dw_mmc*</font><br>
drivers/mmc/host/dw_mmc.c drivers/mmc/host/dw_mmc.h
drivers/mmc/host/dw_mmc-pci.c drivers/mmc/host/dw_mmc-pltfm.h<br>
<font color="#cc0000">drivers/mmc/host/dw_mmc-exynos.c</font> <font color="#cc0000">drivers/mmc/host/dw_mmc-k3.c </font>
drivers/mmc/host/dw_mmc-pltfm.c <font color="#cc0000">drivers/mmc/host/dw_mmc-rockchip.c</font><br>
<br>
Thanks,<br>
- Yakir<br>
<br>
<blockquote cite="mid:105A0032-83A0-4B75-AE94-258F12451670@gmail.com" type="cite">
<pre wrap="">Best regards,
Jingoo Han
</pre>
<blockquote type="cite">
<pre wrap="">drivers/gpu/drm/exynos/exynos_dp_core.c | 1416 --------------------
drivers/gpu/drm/exynos/exynos_dp_core.h | 282 ----
drivers/gpu/drm/exynos/exynos_dp_reg.c | 1263 -----------------
drivers/gpu/drm/rockchip/Kconfig | 9 +
drivers/gpu/drm/rockchip/Makefile | 1 +
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 390 ++++++
drivers/phy/Kconfig | 7 +
drivers/phy/Makefile | 1 +
drivers/phy/phy-rockchip-dp.c | 185 +++
include/drm/bridge/analogix_dp.h | 40 +
30 files changed, 4325 insertions(+), 3172 deletions(-)
create mode 100644 Documentation/devicetree/bindings/drm/bridge/analogix_dp.txt
create mode 100644 Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt
create mode 100644 Documentation/devicetree/bindings/video/analogix_dp-rockchip.txt
create mode 100644 drivers/gpu/drm/bridge/analogix_dp_core.c
create mode 100644 drivers/gpu/drm/bridge/analogix_dp_core.h
create mode 100644 drivers/gpu/drm/bridge/analogix_dp_reg.c
rename drivers/gpu/drm/{exynos/exynos_dp_reg.h => bridge/analogix_dp_reg.h} (62%)
create mode 100644 drivers/gpu/drm/exynos/analogix_dp-exynos.c
delete mode 100644 drivers/gpu/drm/exynos/exynos_dp_core.c
delete mode 100644 drivers/gpu/drm/exynos/exynos_dp_core.h
delete mode 100644 drivers/gpu/drm/exynos/exynos_dp_reg.c
create mode 100644 drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
create mode 100644 drivers/phy/phy-rockchip-dp.c
create mode 100644 include/drm/bridge/analogix_dp.h
--
1.9.1
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
<br>
</div></blockquote></body></html>