<div dir="ltr">Hi Thierry,<br><div class="gmail_extra"><br><div class="gmail_quote">2015-08-21 9:16 GMT-04:00 Thierry Reding <span dir="ltr"><<a href="mailto:treding@nvidia.com" target="_blank">treding@nvidia.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Fri, Aug 21, 2015 at 08:24:16PM +0900, Jingoo Han wrote:<br>
> On 2015. 8. 21., at PM 7:01, Yakir Yang <<a href="mailto:ykk@rock-chips.com">ykk@rock-chips.com</a>> wrote:<br>
> ><br>
> > Hi Jingoo,<br>
> ><br>
> >> 在 2015/8/21 16:20, Jingoo Han 写道:<br>
> >>> On 2015. 8. 19., at PM 11:48, Yakir Yang <<a href="mailto:ykk@rock-chips.com">ykk@rock-chips.com</a>> wrote:<br>
> >><br>
> >> .....<br>
> >><br>
> >>> .../bindings/video/analogix_dp-rockchip.txt | 83 ++<br>
> >>> .../devicetree/bindings/video/exynos_dp.txt | 51 +-<br>
> >>> arch/arm/boot/dts/exynos5250-arndale.dts | 10 +-<br>
> >>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 10 +-<br>
> >>> arch/arm/boot/dts/exynos5250-snow.dts | 12 +-<br>
> >>> arch/arm/boot/dts/exynos5250-spring.dts | 12 +-<br>
> >>> arch/arm/boot/dts/exynos5420-peach-pit.dts | 12 +-<br>
> >>> arch/arm/boot/dts/exynos5420-smdk5420.dts | 10 +-<br>
> >>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 12 +-<br>
> >>> drivers/gpu/drm/bridge/Kconfig | 5 +<br>
> >>> drivers/gpu/drm/bridge/Makefile | 1 +<br>
> >>> drivers/gpu/drm/bridge/analogix_dp_core.c | 1382 +++++++++++++++++++<br>
> >>> drivers/gpu/drm/bridge/analogix_dp_core.h | 286 ++++<br>
> >>> drivers/gpu/drm/bridge/analogix_dp_reg.c | 1294 ++++++++++++++++++<br>
> >>> .../exynos_dp_reg.h => bridge/analogix_dp_reg.h} | 270 ++--<br>
> >>> drivers/gpu/drm/exynos/Kconfig | 5 +-<br>
> >>> drivers/gpu/drm/exynos/Makefile | 2 +-<br>
> >>> drivers/gpu/drm/exynos/analogix_dp-exynos.c | 347 +++++<br>
> >> Would you change this file name to "exynos_dp.c"?<br>
> ><br>
> > Sorry, I don't think so ;(<br>
> ><br>
> > I think IP_name+Soc_name would be better in this re-use case.<br>
><br>
> So? Is there the naming rule such as "IP_name+SoC_name"?<br>
><br>
> > Beside I see<br>
> > there are lots of driver named with this format in kernel, such as dw_hdmi & dw_mmc<br>
><br>
> Please look at other dw cases.<br>
> For example, look at dw_pcie.<br>
><br>
> drivers/pci/host/<br>
> pcie-designware.c<br>
> pci-spear13xx.c<br>
> pci-exynos.c<br>
><br>
> In this case, pci-spear13xx.c and pci-exynos.c do not use "IP_name+SoC_name", even though these are dw IPs.<br>
><br>
> Also, naming consistency is more important.<br>
> Now, Exynos DRM files are using "exynos_drm_" prefix.<br>
><br>
> drivers/gpu/drm/exynos/<br>
> exynos_drm_buf.c<br>
> exynos_drm_core.c<br>
> ....<br>
><br>
> However, "analogix_dp-exynos.c" looks very inconsistent.<br>
><br>
> If there is no strict naming rule, please use "exynos_dp.c"<br>
> or "exynos_drm_dp.c".<br>
<br>
</div></div>Exynos DRM maintainers get to pick their filenames, so Yakir, please<br>
rename as Jingoo suggested.<br>
<br>
Even if you didn't the first thing that would go into the Exynos DRM<br>
driver tree after this is merged is a rename patch anyway.<br>
<span class="HOEnZb"><font color="#888888"><br></font></span></blockquote><div><br></div><div><div style="font-size:14px">Okay, thanks for your remind ;)</div><div style="font-size:14px"><br></div><div style="font-size:14px">- Yakir</div></div><div style="font-size:14px"><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="HOEnZb"><font color="#888888">
Thierry<br>
</font></span><br>_______________________________________________<br>
Linux-rockchip mailing list<br>
<a href="mailto:Linux-rockchip@lists.infradead.org">Linux-rockchip@lists.infradead.org</a><br>
<a href="http://lists.infradead.org/mailman/listinfo/linux-rockchip" rel="noreferrer" target="_blank">http://lists.infradead.org/mailman/listinfo/linux-rockchip</a><br>
<br></blockquote></div><br></div></div>