<p dir="ltr"><br>
On Oct 23, 2015 6:32 AM, "Eric Anholt" <<a href="mailto:eric@anholt.net">eric@anholt.net</a>> wrote:<br>
><br>
> Caught by the kbuild test robot.<br>
><br>
> Signed-off-by: Eric Anholt <<a href="mailto:eric@anholt.net">eric@anholt.net</a>><br>
> ---<br>
> drivers/gpu/drm/vc4/vc4_crtc.c | 3 ++-<br>
> drivers/gpu/drm/vc4/vc4_hvs.c | 8 ++++----<br>
> 2 files changed, 6 insertions(+), 5 deletions(-)<br>
><br>
> diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c<br>
> index a3a77dd..32c0348 100644<br>
> --- a/drivers/gpu/drm/vc4/vc4_crtc.c<br>
> +++ b/drivers/gpu/drm/vc4/vc4_crtc.c<br>
> @@ -401,7 +401,8 @@ static void vc4_crtc_atomic_flush(struct drm_crtc *crtc,<br>
> dlist_next++;<br>
><br>
> HVS_WRITE(SCALER_DISPLISTX(vc4_crtc->channel),<br>
> - (u32 *)vc4_crtc->dlist - (u32 *)vc4->hvs->dlist);<br>
> + (u32 __iomem *)vc4_crtc->dlist -<br>
> + (u32 __iomem *)vc4->hvs->dlist);<br>
><br>
> /* Make the next display list start after ours. */<br>
> vc4_crtc->dlist_size -= (dlist_next - vc4_crtc->dlist);<br>
> diff --git a/drivers/gpu/drm/vc4/vc4_hvs.c b/drivers/gpu/drm/vc4/vc4_hvs.c<br>
> index ab1673f..4d81d43 100644<br>
> --- a/drivers/gpu/drm/vc4/vc4_hvs.c<br>
> +++ b/drivers/gpu/drm/vc4/vc4_hvs.c<br>
> @@ -75,10 +75,10 @@ void vc4_hvs_dump_state(struct drm_device *dev)<br>
> for (i = 0; i < 64; i += 4) {<br>
> DRM_INFO("0x%08x (%s): 0x%08x 0x%08x 0x%08x 0x%08x\n",<br>
> i * 4, i < HVS_BOOTLOADER_DLIST_END ? "B" : "D",<br>
> - ((uint32_t *)vc4->hvs->dlist)[i + 0],<br>
> - ((uint32_t *)vc4->hvs->dlist)[i + 1],<br>
> - ((uint32_t *)vc4->hvs->dlist)[i + 2],<br>
> - ((uint32_t *)vc4->hvs->dlist)[i + 3]);<br>
> + readl((u32 __iomem *)vc4->hvs->dlist + 0),<br>
> + readl((u32 __iomem *)vc4->hvs->dlist + 1),<br>
> + readl((u32 __iomem *)vc4->hvs->dlist + 2),<br>
> + readl((u32 __iomem *)vc4->hvs->dlist + 3));</p>
<p dir="ltr">Looks like you lost the +i here, no?</p>
<p dir="ltr">> }<br>
> }<br>
><br>
> --<br>
> 2.6.1<br>
><br>
> _______________________________________________<br>
> dri-devel mailing list<br>
> <a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
</p>