<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [regression bisected] Stuttering in games caused by commit 4dfd6486 "drm: Use vblank timestamps to guesstimate how many vblanks were missed"" href="https://bugs.freedesktop.org/show_bug.cgi?id=93147#c10">Comment # 10</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [regression bisected] Stuttering in games caused by commit 4dfd6486 "drm: Use vblank timestamps to guesstimate how many vblanks were missed"" href="https://bugs.freedesktop.org/show_bug.cgi?id=93147">bug 93147</a> from <a class="email" href="mailto:mario.kleiner@tuebingen.mpg.de" title="Mario Kleiner <mario.kleiner@tuebingen.mpg.de>"> Mario Kleiner</a> <pre>Created <a href="attachment.cgi?id=120301" name="attach_120301" title="First proposed patch to fix this on radeon-kms">attachment 120301</a> <a href="attachment.cgi?id=120301&action=edit" title="First proposed patch to fix this on radeon-kms">[details]</a> <a href='page.cgi?id=splinter.html&bug=93147&attachment=120301'>[review]</a> First proposed patch to fix this on radeon-kms Ok, the attached patch works on my test systems with my timing tests and hardware timing measurement equipment and i think it hopefully avoids the races Ville and me could come up with so far. One thing which might make sense for improved efficiency is to replace the udelay(5) in the radeon_flip_work_func() with a usleep_range() that avoids polling and sleeps the right minimum amount of time. I'll try to try that today. For the line buffer sizes for < DCE4 i just guessed values which are hopefully big enough to cover earlier asics. I think too big is not a big problem for correctness, but potentially for performance under higher graphics load.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>