[farsight2/master] Invert the result of _compare_codec_lists to get the right result, and document the function

Olivier Crête olivier.crete at collabora.co.uk
Tue Dec 23 15:20:31 PST 2008


---
 gst/fsrtpconference/fs-rtp-session.c |   13 ++++++++++++-
 1 files changed, 12 insertions(+), 1 deletions(-)

diff --git a/gst/fsrtpconference/fs-rtp-session.c b/gst/fsrtpconference/fs-rtp-session.c
index a099818..bb9c94e 100644
--- a/gst/fsrtpconference/fs-rtp-session.c
+++ b/gst/fsrtpconference/fs-rtp-session.c
@@ -1376,6 +1376,16 @@ fs_rtp_session_invalidate_pt (FsRtpSession *session, gint pt,
   FS_RTP_SESSION_UNLOCK (session);
 }
 
+/**
+ * _compare_codec_lists:
+ * @list1: a #GList of #FsCodec
+ * @list2: a #GList of #FsCodec
+ *
+ * Compares two lists of #FsCodec
+ *
+ * Returns: TRUE if they are identical, FALSE otherwise
+ */
+
 static gboolean
 _compare_codec_lists (GList *list1, GList *list2)
 {
@@ -1433,7 +1443,8 @@ fs_rtp_session_negotiate_codecs (FsRtpSession *session, GList *remote_codecs,
       gboolean clear_pts = FALSE;
       int pt;
 
-      is_new = _compare_codec_lists (session->priv->negotiated_codecs,
+      is_new = !_compare_codec_lists (
+          session->priv->negotiated_codecs,
           new_negotiated_codecs);
 
       /* Lets remove the codec bin for any PT that has changed type */
-- 
1.5.6.5




More information about the farsight-commits mailing list