<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED --- - fonts.conf.in update for Windows cross-compiling" href="https://bugs.freedesktop.org/show_bug.cgi?id=69836#c2">Comment # 2</a> on <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED --- - fonts.conf.in update for Windows cross-compiling" href="https://bugs.freedesktop.org/show_bug.cgi?id=69836">bug 69836</a> from <a class="email" href="mailto:jehan@zemarmot.net" title="Jehan <jehan@zemarmot.net>"> Jehan</a> <pre>Created <a href="attachment.cgi?id=86781" name="attach_86781" title="Do not ignore missing default conf.d/">attachment 86781</a> <a href="attachment.cgi?id=86781&action=edit" title="Do not ignore missing default conf.d/">[details]</a> <a href='page.cgi?id=splinter.html&bug=69836&attachment=86781'>[review]</a> Do not ignore missing default conf.d/ Hi Akira, yes I just tested on master, your change looks good. Could I suggest an additional patch to this change? See the included patch. Basically I propose to just replace ignore_missing="yes" on the include by ignore_missing="no". For user-set include, one is free to ignore missing configuration (or to update the default ones). But for the default configuration, I think most users expects them to work out of the box. Consequently we should warn the user if for some reason the default conf.d/ was broken. I hope that makes sense. :-) So I'd propose this patch + your proposed Makefile.am patch would improve default configuration. Thanks!</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>