<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:freedesktop@behdad.org" title="Behdad Esfahbod <freedesktop@behdad.org>"> <span class="fn">Behdad Esfahbod</span></a>
</span> changed
<a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED --- - size specific design selection support in OS/2 table version 5"
href="https://bugs.freedesktop.org/show_bug.cgi?id=71287">bug 71287</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>freedesktop@behdad.org
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED --- - size specific design selection support in OS/2 table version 5"
href="https://bugs.freedesktop.org/show_bug.cgi?id=71287#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED --- - size specific design selection support in OS/2 table version 5"
href="https://bugs.freedesktop.org/show_bug.cgi?id=71287">bug 71287</a>
from <span class="vcard"><a class="email" href="mailto:freedesktop@behdad.org" title="Behdad Esfahbod <freedesktop@behdad.org>"> <span class="fn">Behdad Esfahbod</span></a>
</span></b>
<pre>Thanks. Some more feedback:
- Why the renaming in FcConfigEvaluate()? It takes a large chunk of the patch
unnecessarily,
- In _FcValuePrintFile, perhaps better to print range using () instead of {}?
- I think we want to make the FC_SIZE to be able to accept both double and
range. I think you've got that already. As such, please limit
FcDefaultSubstitute changes to use double when a range is not necessary.
Ideally we shouldn't see any changes to that function whatsoever. In fact, I
think it would be fine to expect that the query-pattern has a double size, not
a range size. Think of this as FC_LANG. The font patterns have a FcLangSet
object for FC_LANG, but query-pattern has a string FC_LANG.
- I'd separate the cache version jump to a separate commit.
- FcCompareSizeRange() should return the minimum distance from one range to
another. If the two ranges overlap, that's zero. Otherwise, return the
minimum distance from one range's end to the other's.
- Again, in FcNameParse, keep thee AddDouble as is. Possibly add a way to
specify a range, but that's not really important at least initially.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>